Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error TS2430: Interface 'ConfirmProps' incorrectly extends interface 'ModalProps'. #1618

Closed
almost opened this issue Apr 24, 2017 · 2 comments

Comments

@almost
Copy link

almost commented Apr 24, 2017

Steps

Import stuff from a file in project:

import { Grid } from 'semantic-ui-react';

Compile with Typescript

Expected Result

It compiles

Actual Result

It fails to compile. With error:

ERROR in /**REDACTED**/node_modules/semantic-ui-react/dist/commonjs/addons/Confirm/Confirm.d.ts
(4,18): error TS2430: Interface 'ConfirmProps' incorrectly extends interface 'ModalProps'.
  Property 'content' is optional in type 'ConfirmProps' but required in type 'ModalProps'.

Version

0.68.1 has bug, 0.68.0 does not

Testcase

See above

@levithomason
Copy link
Member

levithomason commented Apr 24, 2017

There's a PR open for this, #1611. Duplicate #1612. Thanks for the report.

@levithomason
Copy link
Member

Released in [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants