[🐛 Bug]: selenium seems not to close /dev/null at the end of the session

[stefanoborini]

What happened?

Not sure if this is a chromedriver issue or a selenium issue, but I suspect selenium.

/dev/null seems to be dangling open at the end of a pytest run with a trivial driver creation in a fixture.

How can we reproduce the issue?

import pytest                                                                             
from selenium import webdriver                                                            
                                                                                          
@pytest.fixture                                                                           
def driver():                                                                             
    driver = webdriver.Chrome()                                                           
    try:                                                                                  
        yield driver                                                                      
    finally:                                                                              
        driver.close()                                                                    
                                                                                          
def test_xxx(driver):                                                                     
    print(driver)

Relevant log output

Platform darwin -- Python 3.11.3, pytest-7.4.0, pluggy-1.0.0
rootdir: <redacted>
configfile: pytest.ini
plugins: xprocess-0.22.2, order-1.2.dev0, dependency-0.5.1, xdist-3.3.1, jira-xray-0.8.9
collected 1 item                                                                                                                                                                                                            

test_xxx.py <selenium.webdriver.chrome.webdriver.WebDriver (session="4f13dd17af93af529736ef6c5e12813b")>
.Exception ignored in: <_io.FileIO name='/dev/null' mode='wb' closefd=True>
Traceback (most recent call last):
  File "<redacted>/python3.11/site-packages/_pytest/runner.py", line 139, in runtestprotocol
    item.funcargs = None  # type: ignore[attr-defined]
    ^^^^^^^^^^^^^
ResourceWarning: unclosed file <_io.BufferedWriter name='/dev/null'>

Operating System

macOS 13.5.1

Selenium version

selenium==4.11.2 on python 3.11

What are the browser(s) and version(s) where you see this issue?

Chrome 116.0.5845.110

What are the browser driver(s) and version(s) where you see this issue?

Downloaded by selenium

Are you using Selenium Grid?

No response

[github-actions]

@stefanoborini, thank you for creating this issue. We will troubleshoot it as soon as we can.

---

Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then I-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C), add the applicable G-* label, and it will provide the correct link and auto-close the issue.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

[titusfortner]

We're working on that in this #12637

[graingert]

I'm still seeing this issue with Firefox: https://github.com/urllib3/urllib3/actions/runs/7248513708/job/19744578897?pr=2842#step:7:6552

[graingert]

Actually could this be a different issue?

selenium/py/selenium/webdriver/firefox/firefox_binary.py

Line 44 in 29b6dc7

self._log_file = log_file or open(os.devnull, "wb")

[graingert]

yeah sorry this is a different issue #13328

[graingert]

@titusfortner I think you can close this one?

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.