Skip to content

ability to specify runtime as argument to the .deploy method? #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RafalSkolasinski opened this issue Mar 22, 2021 · 1 comment
Closed

Comments

@RafalSkolasinski
Copy link
Contributor

It may be cleaner to specify runtime as argument to the .deploy method so we can avoid modification of the pipeline instance state.

This way it will be more transparent what remote we deploy to - and also possible to deploy to two remotes at the same time.

For example:

# Talking to docker runtime
docker_runtime = classifier.deploy(runtime=DockerRuntime(...))
docker_runtime.wait_ready()
docker_runtime.remote(payload=np.array([[1, 2, 3, 4]]))

# Talking to k8s runtime
k8s_runtime = classifier.deploy(runtime=KubernetesRuntime(...))
k8s_runtime.wait_ready()
k8s_runtime.remote(payload=np.array([[1, 2, 3, 4]]))

One present problem is that information about upload is included in the artefact itself in the .save and then .upload calls.

@ukclivecox
Copy link
Contributor

No needed anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants