Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rearchitect/refactor runtime options to provide consistent mappings #150

Closed
axsaucedo opened this issue Jun 20, 2021 — with Board Genius Sync · 0 comments
Closed
Assignees

Comments

Copy link
Contributor

axsaucedo commented Jun 20, 2021

Currently if the following code is run, the model created would still be running on Docker instead of kubernetes (main difference being the RuntimeOptions vs SeldonCoreOptions)

from tempo.serve.metadata import RuntimeOptions, KubernetesOptions, InsightsOptions
from tempo.serve.constants import DefaultInsightsK8sEndpoint
from tempo.seldon.k8s import SeldonCoreOptions
from tempo import deploy

kubernetes_options = RuntimeOptions(
        k8s_options=KubernetesOptions(
            namespace="seldon",
            authSecretName="minio-secret"
        ),
        insights_options=InsightsOptions(
            worker_endpoint=DefaultInsightsK8sEndpoint
        )
    )

remote_model = deploy(pipeline, kubernetes_options)

The following code would be the one that would run correctly

from tempo.serve.metadata import RuntimeOptions, KubernetesOptions, InsightsOptions
from tempo.serve.constants import DefaultInsightsK8sEndpoint
from tempo.seldon.k8s import SeldonCoreOptions
from tempo import deploy

kubernetes_options = SeldonCoreOptions(
        k8s_options=KubernetesOptions(
            namespace="seldon",
            authSecretName="minio-secret"
        ),
        insights_options=InsightsOptions(
            worker_endpoint=DefaultInsightsK8sEndpoint
        )
    )

remote_model = deploy(pipeline, kubernetes_options)

We should re-explore the different options in runtime and how the combination of these would map into their respective deployments. Initially there are other things to address such as there not being a SeldonCoreOptions in seldon/docker.py, but generally it would be a good oportunity to review the available dataclasses.

This coudl also be a good opportunity to reduce the different ways in which runtimes can be used, and simplifying the code paths.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant