Use a non-ambigious syntax for generating hstore SQL

hstore(ARRAY['key', 'value'], ARRAY['key2', 'value2'])

Might be mistaken for another form:

hstore(ARRAY['key'], ARRAY['value'])

By using the following syntax, there is not ambigiuation:

hstore('key', value') || hstore('key2', 'value2')

Author: Photonios

psqlextra/expressions.py

@@ -46,15 +46,15 @@ def as_sql(self, compiler, connection):
         for key, value in self.value.items():
             if hasattr(value, 'as_sql'):
                 sql, params = value.as_sql(compiler, connection)
-                result.append('ARRAY[\'%s\', %s]' % (
+                result.append('hstore(\'%s\', %s)' % (
                     key, sql % params))
             elif value is not None:
-                result.append('ARRAY[\'%s\', \'%s\']' % ((
+                result.append('hstore(\'%s\', \'%s\')' % ((
                     key, value)))
             else:
-                result.append('ARRAY[\'%s\', NULL]' % key)
+                result.append('hstore(\'%s\', NULL)' % key)
 
-        return 'hstore(%s)' % ','.join(result), []
+        return '%s' % ' || '.join(result), []
 
 
 class HStoreColumn(expressions.Col):