Potential breaking changes from 0.23.0 to 0.24.0

[phungleson]

Description

Hey peeps, I encounter 2 errors when trying to upgrade from 0.23.0 to 0.24.0.

Steps to Reproduce

First one, this used to work in 0.23.0

Query::insert()
        .into_table(Shops::Table)
        .columns(vec![
            ...
            Shops::GroupId,
            ...
        ])
        .exprs(vec![
            ...
            Expr::value(group_id.clone()),

With group_id is &Option<Uuid>

and

group_id UUID REFERENCES groups (id) ON DELETE CASCADE,

But it throws an error in 0.24.0

column \"group_id\" is of type uuid but expression is of type boolean

Second one, this used to work in 0.23.0

Query::insert()
        .into_table(Shops::Table)
        .columns(vec![
            ...
            Shops::Description,
            ...
        ])
        .exprs(vec![
            ...
            Expr::value(description.clone()),

With description is &Option<String>

and

description VARCHAR,

But it throws an error in 0.24.0

incorrect binary data format in bind parameter 4

Expected Behavior

I downgraded back to 0.23.0 and they all working again.

Actual Behavior

Provided.

Reproduces How Often

Provided.

Versions

Provided.

Additional Information

I am testing with postgres, let me know if you need me to debug further.

Thanks!

[ikrivosheev]

@phungleson hello, thank you for the report, I will look this bug tomorrow...

[tyt2y3]

Yeah it seems to have caught by our CI now, it's only a Postgres issue apparently

[billy1624]

I guess the bug originate from the fact that we bind Option<T> as Option::<bool>::None if it's a None

• sea-query/sea-query-driver/src/sqlx_mysql.rs

  Lines 71 to 78 in 09a75b7

  	macro_rules! bind_box {
  	( $v: expr ) => {
  	match $v {
  	Some(v) => query.bind(v.as_ref()),
  	None => query.bind(None::<bool>),
  	}
  	};
  	}

• sea-query/sea-query-driver/src/sqlx_postgres.rs

  Lines 77 to 84 in 09a75b7

  	macro_rules! bind_box {
  	( $v: expr ) => {
  	match $v {
  	Some(v) => query.bind(v.as_ref()),
  	None => query.bind(None::<bool>),
  	}
  	};
  	}

• sea-query/sea-query-driver/src/sqlx_sqlite.rs

  Lines 71 to 78 in 09a75b7

  	macro_rules! bind_box {
  	( $v: expr ) => {
  	match $v {
  	Some(v) => query.bind(v.as_ref()),
  	None => query.bind(None::<bool>),
  	}
  	};
  	}

[ikrivosheev]

@phungleson @tyt2y3 @billy1624 I apologize for the mistake. I did PR)

[Sytten]

My CI tests broke for 0.24 but I didnt have time to investigate, I will report back

[phungleson]

Thanks for quick turn around @ikrivosheev 👍

[tyt2y3]

Thank you @ikrivosheev
A new release has been made 0.24.2