Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing okapi support #2135

Closed
m4tx opened this issue Mar 3, 2024 · 1 comment · Fixed by #2136
Closed

Missing okapi support #2135

m4tx opened this issue Mar 3, 2024 · 1 comment · Fixed by #2136

Comments

@m4tx
Copy link
Contributor

m4tx commented Mar 3, 2024

Description

Raising this as a bug, both because there is a broken example on the repo, and because the breakage in question hasn't been communicated as a major version bump/info in changelog.

I can see that the support to rocket_okapi has been added in #1071, and then removed in c3b7256. This has been included as part of 0.12.5 release (0.12.4...0.12.5), but its changelog doesn't mention this (breaking) change.

It would be nice to get the rocket_okapi support back or get a reason for removing the support and in this case, removal of the example and feature flag from the repository. Now it's misleading, as the example suggests that the support is there, while it doesn't work.

Steps to Reproduce

  1. Clone the sea-orm repo
  2. cd examples/rocket_okapi_example
  3. cargo run

Expected Behavior

The example compiles and runs.

Actual Behavior

It fails with failed to resolve: use of undeclared crate or module rocket_okapi (among other errors).

Reproduces How Often

Always

Workarounds

I looked at the git history and found out the support has been silently removed in c3b7256.

Versions

  • sea-orm v1.0.0-rc.1
  • sea-orm-rocket v0.5.4
  • DB: SQLite (although it doesn't really matter, as the issue happens at the compile time)
  • OS: Arch Linux
@m4tx
Copy link
Contributor Author

m4tx commented Mar 3, 2024

Ah, now I see it's been removed because when #1959 was created, okapi hasn't been updated to work with the latest Rocket version yet... I can spin up a PR that'll fix this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant