Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing bae with darling #1732

Closed
billy1624 opened this issue Jun 30, 2023 · 2 comments · Fixed by #1739 · May be fixed by #1412 or #1560
Closed

Replacing bae with darling #1732

billy1624 opened this issue Jun 30, 2023 · 2 comments · Fixed by #1739 · May be fixed by #1412 or #1560
Milestone

Comments

@billy1624
Copy link
Member

Motivation

Currently, we depends on https://crates.io/crates/bae to parse the procedural macro attributes. However, it's no longer maintained and still depends on syn v1.

Proposed Solutions

We want to drop the use of https://crates.io/crates/bae and https://crates.io/crates/bae2 completely. And switch to https://crates.io/crates/darling instead.

@billy1624 billy1624 added this to the 0.12.x milestone Jun 30, 2023
This was linked to pull requests Jun 30, 2023
@billy1624
Copy link
Member Author

@billy1624
Copy link
Member Author

billy1624 commented Jun 30, 2023

Don't try to rewrite all procedural macros and parse proc_macro attributes with darling.

Just focus on keeping the behaviour of proc_macro the same. While drop the use of bae, i.e. the line below

bae = { version = "1", package = "bae2", default-features = false, optional = true }

These three files should be changed
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant