Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FR] Should we derive Eq as well? #1037

Closed
frederikhors opened this issue Sep 12, 2022 · 3 comments · Fixed by #988
Closed

[FR] Should we derive Eq as well? #1037

frederikhors opened this issue Sep 12, 2022 · 3 comments · Fixed by #988

Comments

@frederikhors
Copy link
Contributor

Motivation

I generated the first entity with SeaORM.

But Clippy is telling me this:

image

Proposed Solutions

Should we derive Eq as well?
@tyt2y3
Copy link
Member

tyt2y3 commented Sep 13, 2022

We have to make sure there is no f64 in the entity in order to add that.

@billy1624
Copy link
Member

billy1624 commented Sep 13, 2022 •
edited
Loading

Hey @frederikhors, thanks for the feature request! We notice this new clippy lint has been stabilized. We're working on it, please check the PR at #988

@billy1624
Copy link
Member

Duplicate of #965

@billy1624 billy1624 marked this as a duplicate of #965 Sep 13, 2022
@billy1624 billy1624 linked a pull request Sep 13, 2022 that will close this issue
Struct / enum derive PartialEq should also derive Eq #988
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
SeaQL Dev Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Struct / enum derive PartialEq should also derive Eq w93163red/sea-orm
3 participants
@tyt2y3 @billy1624 @frederikhors