Skip to content

Conversation

@fahim-ahmed05
Copy link
Contributor

@fahim-ahmed05 fahim-ahmed05 commented Oct 24, 2025

Summary

This PR updates the checkver mechanism to include pre-releases. Helium marks new updates as pre-releases in its GitHub releases, which delays updates for Scoop users. Including pre-release versions ensures users stay up to date, particularly with Chromium updates, which are important for security.

Code Changes

"checkver": {
    "url": "https://api.github.com/repos/imputnet/helium-windows/releases",
    "jsonpath": "$.[0].tag_name"
}
  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

Summary by CodeRabbit

  • Chores
    • Switched version detection to programmatic release data retrieval for more accurate update checks.
    • Updated packaged release to v0.5.8.1 for both 64-bit and ARM64 architectures, including refreshed download artifacts.

@coderabbitai
Copy link

coderabbitai bot commented Oct 24, 2025

Walkthrough

Bumped helium package from 0.5.7.1 to 0.5.8.1 (download URLs, SHA256, extract_dir) and replaced the checkver single github string with a GitHub Releases API url plus jsonpath to extract tag_name.

Changes

Cohort / File(s) Summary
Manifest update
bucket/helium.json
Version bump 0.5.7.1 → 0.5.8.1 for 64bit and arm64 entries (download URLs, sha256, extract_dir) and checkver changed from a single github string to an API url + jsonpath extracting tag_name.

Sequence Diagram(s)

sequenceDiagram
    participant Scoop as Scoop/autoupdate
    participant GitHub as GitHub Releases API
    Note over Scoop,GitHub: New flow (uses API + jsonpath)
    Scoop->>GitHub: GET /repos/:owner/:repo/releases/latest
    GitHub-->>Scoop: JSON { "tag_name": "v0.5.8.1", ... }
    Scoop->>Scoop: Apply jsonpath -> extract tag_name
    Scoop->>Scoop: Compare tag to manifest version
    alt update available
        Scoop->>User: notify/update manifest/autoupdate
    end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

review-needed

Suggested reviewers

  • aliesbelik

Poem

🐰 I hopped to the releases, nose to the sky,
Found tag v0.5.8.1 with a cheerful sigh,
API whispers the truth, jsonpath so neat,
Manifests updated — a tidy treat! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title "[email protected]: Update checkver to detect pre-release" follows the conventional PR format required by the repository (<manifest-name[@version]>: <general summary>) and clearly communicates the primary change. The title accurately reflects the main objective of the pull request: updating the checkver mechanism to detect pre-releases so that Scoop users receive timely updates for Helium. The title is concise, specific, and a teammate scanning the history would immediately understand that this involves version 0.5.8.1 and a checkver improvement.
Description Check ✅ Passed The pull request description is mostly complete and follows the template structure. It includes a clear "Summary" section explaining the motivation and purpose of the change, shows the actual code changes being made, and includes both required checklist items marked as completed (conventional PR title format and reading the Contributing Guide). The description provides good context about why the change matters, specifically mentioning the security importance of Chromium updates. While there is no explicit issue reference (Closes/Relates to), this appears to be optional based on the template formatting, and the description successfully addresses the core requirements.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5b29b06 and 756611c.

📒 Files selected for processing (1)
  • bucket/helium.json (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: WindowsPowerShell
🔇 Additional comments (2)
bucket/helium.json (2)

2-2: Version bump and artifacts are consistent.

The version was bumped from 0.5.7.1 to 0.5.8.1 across all architecture entries, and the corresponding URLs, hashes, and extract directories are updated to match. The hash values appear valid (64-character hex strings for SHA256).

Also applies to: 8-10, 13-15


33-36: Checkver implementation is working correctly—pre-releases are detected and extracted as intended.

Verification confirms:

  • The GitHub Releases API endpoint includes pre-releases in the response (0.5.8.1 is marked prerelease: true).
  • The jsonpath $.[0].tag_name correctly extracts the newest release tag.
  • Tag format 0.5.8.1 requires no version manipulation.

The checkver will reliably pick up pre-releases, meeting the PR objective.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

Your changes did not pass all checks.

Please address the issues in the manifest and comment starting with /verify to rerun the checks.

helium

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@fahim-ahmed05 fahim-ahmed05 changed the title [email protected]: Update checkver to detect pre-release [email protected]: Update checkver to detect pre-release Oct 24, 2025
@fahim-ahmed05
Copy link
Contributor Author

/verify

@github-actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

helium

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@fahim-ahmed05 fahim-ahmed05 mentioned this pull request Oct 24, 2025
2 tasks
@SorYoshino
Copy link
Contributor

The Extras bucket generally does not allow applications to be updated to pre-release versions.

If you want to use a pre-release version, you should add helium-pre to the Versions bucket instead of enabling the manifest in the Extras bucket to update to a pre-release build.

@fahim-ahmed05
Copy link
Contributor Author

@SorYoshino submitted to the versions bucket. thanks!

PR: ScoopInstaller/Versions#2538

@fahim-ahmed05 fahim-ahmed05 deleted the helium branch October 25, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants