-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[email protected]: Update checkver to detect pre-release #16458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughBumped helium package from 0.5.7.1 to 0.5.8.1 (download URLs, SHA256, extract_dir) and replaced the Changes
Sequence Diagram(s)sequenceDiagram
participant Scoop as Scoop/autoupdate
participant GitHub as GitHub Releases API
Note over Scoop,GitHub: New flow (uses API + jsonpath)
Scoop->>GitHub: GET /repos/:owner/:repo/releases/latest
GitHub-->>Scoop: JSON { "tag_name": "v0.5.8.1", ... }
Scoop->>Scoop: Apply jsonpath -> extract tag_name
Scoop->>Scoop: Compare tag to manifest version
alt update available
Scoop->>User: notify/update manifest/autoupdate
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with helium
|
|
/verify |
|
All changes look good. Wait for review from human collaborators. helium
|
|
The Extras bucket generally does not allow applications to be updated to pre-release versions. If you want to use a pre-release version, you should add |
|
@SorYoshino submitted to the versions bucket. thanks! |
Summary
This PR updates the
checkvermechanism to include pre-releases. Helium marks new updates as pre-releases in its GitHub releases, which delays updates for Scoop users. Including pre-release versions ensures users stay up to date, particularly with Chromium updates, which are important for security.Code Changes
<manifest-name[@version]|chore>: <general summary of the pull request>Summary by CodeRabbit