-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
googlechrome: Remove persist User Data #13853
Conversation
All changes look good. Wait for review from human collaborators. googlechrome
|
for versions/googlechrome-beta |
All changes look good. Wait for review from human collaborators. googlechrome
|
please review this ty @aliesbelik @sitiom @rashil2000 |
There wasn't any message left for this breaking change. The missing of my chrome profile confused me after the update. At least the old persisted profile data should be copied to AppData and there should be a message notifying the change. |
Also, this made the persisted profile data being isolated and requires a manual deletion. |
@chawyehsu Sorry 'bout that. I didn't realize this would break existing installs, or I would have never accepted it as is. I'll be more careful next time. In my feeble defense, the PR was several months ago, and no one voiced a concern. Perhaps in these kinds of PRs, we should require at least 2, or even 3, approvals before merging. |
Closes #XXXX
Relates to #7573 (comment)
In my humble opinion, it is unnecessary to save User Data in persist.