Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

googlechrome: Remove persist User Data #13853

Merged
merged 4 commits into from
Dec 29, 2024

Conversation

b4imetu
Copy link
Contributor

@b4imetu b4imetu commented Aug 21, 2024

Closes #XXXX

Relates to #7573 (comment)

In my humble opinion, it is unnecessary to save User Data in persist.

Same for Google Chrome - the non portable manifest crashes the browser (linked issue).

  • There is no such problem for Google Chrome.
  • It will cause two Chrome icons with different profiles to appear in the taskbar.
  • The default browser opening method will also open a new profile.

troublesome for ordinary users.
097b1a046725dfab7ad2c330684e221

Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

googlechrome

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

@b4imetu
Copy link
Contributor Author

b4imetu commented Aug 28, 2024

for versions/googlechrome-beta
versions/googlechrome-canary
versions/googlechrome-dev
they do not persist User Data and they work well.

Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

googlechrome

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

@b4imetu
Copy link
Contributor Author

b4imetu commented Nov 13, 2024

please review this ty @aliesbelik @sitiom @rashil2000

@rasa rasa merged commit ab9d397 into ScoopInstaller:master Dec 29, 2024
2 checks passed
@b4imetu b4imetu deleted the b4imetu-googlechrome branch December 29, 2024 18:49
@chawyehsu
Copy link
Member

There wasn't any message left for this breaking change. The missing of my chrome profile confused me after the update.

At least the old persisted profile data should be copied to AppData and there should be a message notifying the change.

@chawyehsu
Copy link
Member

Also, this made the persisted profile data being isolated and requires a manual deletion.

@rasa
Copy link
Member

rasa commented Jan 1, 2025

@chawyehsu Sorry 'bout that. I didn't realize this would break existing installs, or I would have never accepted it as is. I'll be more careful next time.

In my feeble defense, the PR was several months ago, and no one voiced a concern. Perhaps in these kinds of PRs, we should require at least 2, or even 3, approvals before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants