Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Better errors linting inline extends syntax #321

Open
davidpeck-littlemonkey opened this issue Sep 10, 2024 · 5 comments
Open

[3.x] Better errors linting inline extends syntax #321

davidpeck-littlemonkey opened this issue Sep 10, 2024 · 5 comments
Labels
bug Something isn't working linter

Comments

@davidpeck-littlemonkey
Copy link

davidpeck-littlemonkey commented Sep 10, 2024

I've a class person.gd:

class_name Person extends Node

var name: String

when I lint I get:

# gdlint ./person.gd
./person.gd:3: Error: Definition out of order in global scope (class-definitions-order)
Failure: 1 problem found

I would expect either no errors, or some error "inline extends not allowed" but instead it complains about the order of name

@Scony
Copy link
Owner

Scony commented Sep 10, 2024

Looks like bug - thanks for reporting!

@Scony Scony added bug Something isn't working linter labels Sep 10, 2024
@Scony
Copy link
Owner

Scony commented Oct 5, 2024

@davidpeck-littlemonkey what is the version of gdtoolkit you use? With latest main I get no errors with the above.

@Scony Scony added discussion Let's discuss and removed bug Something isn't working linter labels Oct 5, 2024
@Scony
Copy link
Owner

Scony commented Oct 7, 2024

I've checked and I think you're using an outdated gdtoolkit. Please update to the latest one or if I'm wrong, please paste the full gdscript file, as I may be missing some context.

@Scony Scony closed this as not planned Won't fix, can't repro, duplicate, stale Oct 7, 2024
@davidpeck-littlemonkey
Copy link
Author

@Scony sorry for the delay. This was with v3.5.0 (I'm using Godot v3). Is v3 still being maintained?

@Scony Scony reopened this Oct 10, 2024
@Scony
Copy link
Owner

Scony commented Oct 10, 2024

Ok, in that case, I'll need to fix that. Thanks for reporting!

@Scony Scony added bug Something isn't working linter and removed discussion Let's discuss labels Oct 10, 2024
@Scony Scony changed the title Better errors linting inline extends syntax [3.x] Better errors linting inline extends syntax Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working linter
Projects
None yet
Development

No branches or pull requests

2 participants