build wheel from sdist, not src #5266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Apr 21, 2023

.github/workflows/ci-wheels.yml

-Original file line number
+Diff line change
@@ Expand Up / @@ -35,9 +35,7 @@ jobs: @@
         - name: "building"
           shell: bash
           run: |
-            # require build with explicit --sdist and --wheel in order to
-            # get correct version associated with sdist and bdist artifacts
-            pipx run build --sdist --wheel
+            pipx run build
         - uses: actions/upload-artifact@v3
           with:
@@ Expand Down @@

docs/src/whatsnew/latest.rst

-Original file line number
+Diff line change
@@ Expand Up @@
     #. `@bjlittle`_ and `@trexfeathers`_ (reviewer) migrated ``setup.cfg`` to
        ``pyproject.toml``, as motivated by `PEP-0621`_. (:pull:`5262`)
+    #. `@bjlittle`_ adopted `pypa/build`_ recommended best practice to build a
+       binary ``wheel`` from the ``sdist``. (:pull:`5266`)
     .. comment
         Whatsnew author names (@github name) in alphabetical order. Note that,
@@ Expand All @@
     .. _sphinx-design: https://github.com/executablebooks/sphinx-design
     .. _check-manifest: https://github.com/mgedmin/check-manifest
     .. _PEP-0621: https://peps.python.org/pep-0621/
+    .. _pypa/build: https://pypa-build.readthedocs.io/en/stable/

Provide feedback