Skip to content

Added winkel tripel projection class #2442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AgentOxygen wants to merge 7 commits into
base: main
Choose a base branch
from
+25 −0
Open

Added winkel tripel projection class #2442

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d550f65
Added winkel tripel projection class
AgentOxygen Sep 25, 2024
6210860
Cleaned up WinkelTripel super constructor
AgentOxygen Oct 7, 2024
1511ceb
Merge branch 'SciTools:main' into main
AgentOxygen Apr 24, 2025
de76b10
Added Winkel Tripel test
AgentOxygen Apr 24, 2025
31dc6c7
Added baseline image for Winkel Tripel projection
AgentOxygen Apr 24, 2025
ced358f
Update lib/cartopy/crs.py
greglucas May 23, 2025
0d1baff
Update lib/cartopy/crs.py
greglucas May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions lib/cartopy/crs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2539,6 +2539,30 @@ def transform_points(self, src_crs, x, y, z=None, trap=False):
return result


class WinkelTripel(_WarpedRectangularProjection):
Copy link
Contributor

@greglucas greglucas Sep 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to do any of the nan handling here like we are doing in the Robinson projection? i.e. should this subclass Robinson instead if it is similar to that?

Copy link
Author

@AgentOxygen AgentOxygen Oct 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to generate maps containing maps with no problem. Are there other tests for nans that I would need to do?

"""
A Winkel-Tripel projection.

Compromise modified azimuthal projection that is less distorted
and more area-accurate. It is comparable to the Robinson
projection in both appearance and popularity.

The National Geographic Society uses the Winkel-Tripel projection
for most of the maps they produce.
"""

def __init__(self, central_longitude=0.0, globe=None):
globe = globe or Globe(semimajor_axis=WGS84_SEMIMAJOR_AXIS)
proj4_params = [('proj', 'wintri'),
('lon_0', central_longitude)]

super().__init__(proj4_params, central_longitude, globe=globe)

@property
def threshold(self):
return 1e4


class InterruptedGoodeHomolosine(Projection):
"""
Composite equal-area projection emphasizing either land or
Expand Down
Binary file added ...s/mpl/baseline_images/mpl/test_mpl_integration/test_global_map_WinkelTripel.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions lib/cartopy/tests/mpl/test_mpl_integration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,7 @@ def test_simple_global():
(ccrs.ObliqueMercator, dict(azimuth=90., central_latitude=-22)),
id='ObliqueMercator_rotated',
),
ccrs.WinkelTripel,
])
@pytest.mark.mpl_image_compare(style='mpl20')
def test_global_map(proj):
Expand Down
Loading