-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaks Statsample 1.4.0 #3
Comments
There are pretty big differences between statsample Is there some specific reason why you're not updating to the latest statsample? Could you share it here? If it's critical then maybe we can think of adding support. |
We've now upgraded to 1.4.3, the original issue why we stuck to 1.4.0 was: but now I'm applying the workaround I suggested to this issue (check whether all values are equal before calling statsample), so we're no longer affected by the issue and we were able to go to 1.4.3 yesterday and this solves the issue. TL;DR: We moved to statsample 1.4.3, this issue disappeared and you can still use it with Rails 3 |
Cool! Could you send a PR to statsample with your fixes? |
Well, we actually implemented the check in the wrapper we have around statsample. The problem with implementing this in the statsample code is that since the retrieval of the values does the calculation, there's no really elegant way of doing this check. I.e. whenever I retrieve the coefficients, I would have to check whether the y_var is constant or not and return it. I don't have a really good idea for doing this that would not break the interface. |
I'm using the latest version of
I'm using Rails 4.2. I tried locking the gem version to
I think downgrading my gems would help, but I dont want to do that. |
It seems that the latest version of this gem 1.2.0 (https://rubygems.org/gems/statsample-bivariate-extension/versions/1.2.0 ) prevents us from using statsample 1.4.0. It results in an infinite loop of dependency:
Your Gemfile requires gems that depend on each other, creating an infinite loop. Please remove either gem 'statsample' or gem 'statsample-bivariate-extension' and try again.
It can be reproduced by using bundler with this
Gemfile
file in an empty folder:I'm not sure whether this is something you would want to support, nor what the solution is.
The text was updated successfully, but these errors were encountered: