Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaks Statsample 1.4.0 #3

Open
einpaule opened this issue Aug 20, 2015 · 5 comments
Open

Breaks Statsample 1.4.0 #3

einpaule opened this issue Aug 20, 2015 · 5 comments
Labels

Comments

@einpaule
Copy link

It seems that the latest version of this gem 1.2.0 (https://rubygems.org/gems/statsample-bivariate-extension/versions/1.2.0 ) prevents us from using statsample 1.4.0. It results in an infinite loop of dependency:

Your Gemfile requires gems that depend on each other, creating an infinite loop. Please remove either gem 'statsample' or gem 'statsample-bivariate-extension' and try again.

It can be reproduced by using bundler with this Gemfile file in an empty folder:

source 'https://rubygems.org'

gem 'statsample', '1.4.0'

I'm not sure whether this is something you would want to support, nor what the solution is.

@v0dro
Copy link
Member

v0dro commented Aug 20, 2015

There are pretty big differences between statsample 1.4.0 and 2.0.1. The updated bivariate-extensions uses 2.0.1 because they both now use daru for storage of data.

Is there some specific reason why you're not updating to the latest statsample? Could you share it here? If it's critical then maybe we can think of adding support.

@agarie

@einpaule
Copy link
Author

We've now upgraded to 1.4.3, the original issue why we stuck to 1.4.0 was:
SciRuby/statsample#21 (comment)

but now I'm applying the workaround I suggested to this issue (check whether all values are equal before calling statsample), so we're no longer affected by the issue and we were able to go to 1.4.3 yesterday and this solves the issue.

TL;DR: We moved to statsample 1.4.3, this issue disappeared and you can still use it with Rails 3

@v0dro
Copy link
Member

v0dro commented Aug 21, 2015

Cool!

Could you send a PR to statsample with your fixes?

@einpaule
Copy link
Author

Well, we actually implemented the check in the wrapper we have around statsample.

The problem with implementing this in the statsample code is that since the retrieval of the values does the calculation, there's no really elegant way of doing this check. I.e. whenever I retrieve the coefficients, I would have to check whether the y_var is constant or not and return it.

I don't have a really good idea for doing this that would not break the interface.

@bitsapien
Copy link

I'm using the latest version of statsample, but I still get this problem ->

Your bundle requires gems that depend on each other, creating an infinite loop. Please
remove either gem 'statsample' or gem 'statsample-bivariate-extension' and try again.

I'm using Rails 4.2. I tried locking the gem version to 2.0.1, but its dependency reportbuilder's version is conflicting with prawn's version.

  In snapshot (Gemfile.lock):
    prawn (= 2.1.0)

  In Gemfile:
    prawn (~> 2.1.0)

    statsample (>= 2.0.1) was resolved to 2.0.1, which depends on
      reportbuilder (~> 1.4) was resolved to 1.4.0, which depends on
        prawn-svg (~> 0.9.1) was resolved to 0.9.1.11, which depends on
          prawn (>= 0.8.4)

    statsample (>= 2.0.1) was resolved to 2.0.1, which depends on
      reportbuilder (~> 1.4) was resolved to 1.4.0, which depends on
        prawn (~> 0.8.4)

I think downgrading my gems would help, but I dont want to do that.
Please help.

@v0dro v0dro added the bug label Jan 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants