Add ability to assign ruby complex types to GSL::Matrix::Complex #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_obj_to_gsl_complex(1) * Currently the ops on `::Complex` number is handled via rb_funcall(2..) * Added a test for creating `GSL::Complex` by passing `Complex ` type to `GSL::Complex#alloc` * There is an added cost due to the call to rb_funcall(2..) being used since the @real, @image ivars appear to be unset, in addition to this, struct RComplex is not publicly exposed and to use TypedData_Get_Struct(3) this struct would need to be replicated along with all its dependants.
|
Will review in 1-2 days. Little busy right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch Updates
File changes
ext/gsl_native/complex.c
T_COMPLEXinrb_gsl_complex_new(1..2)andrb_gsl_obj_to_gsl_complex(1)::Complextypes are handled viarb_funcall(2..)test/gsl/complex_test.rb
GSL::Complexby passingComplextype toGSL::Complex#allocWhy this way?
@real,@imagefor the Complex object being used appear to be set to nil (reproducible via IRB)VALUE objstruct RComplexsinceRComplexis internal to rubyI would really appreciate a review of the changes. This patch is submitted for #27