Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nmatrix compatibility #33

Merged
merged 35 commits into from
Mar 8, 2016
Merged

Nmatrix compatibility #33

merged 35 commits into from
Mar 8, 2016

Conversation

v0dro
Copy link
Member

@v0dro v0dro commented Mar 2, 2016

@minad this makes rb-gsl compatible with both nmatrix and narray. Request review.

Will add GSL 2.0 functionality soon.

…r nmatrix and updated existing README with nmatrix how-tos.
@v0dro
Copy link
Member Author

v0dro commented Mar 3, 2016

@blackwinter could you also have a look?

@minad
Copy link
Contributor

minad commented Mar 3, 2016

Quite a lot of code. Did you add nmatrix support to all the places where an narray could be used?

@v0dro
Copy link
Member Author

v0dro commented Mar 3, 2016

Yep. Also made some optimizations here n there. Also, creating NArray views from GSL objects was causing GC problems so views will not be supported by NMatrix.

@v0dro v0dro force-pushed the nmatrix_compatibility branch 3 times, most recently from 5af7eac to 19717b1 Compare March 3, 2016 19:43
travis

travis

travis

travis
travis changes

travis changes

travis changes

travis

travis

travis again

minor removal

travis

t
@v0dro
Copy link
Member Author

v0dro commented Mar 3, 2016

I'll be adding GSL 2.0 support next. Any suggestions?

@v0dro
Copy link
Member Author

v0dro commented Mar 4, 2016

@ktns I have merged your GSL 2.1 changes from #30 for compatibility with GSL 2.1. I'm happy to say that rb-gsl is now comfortably working with all GSL versions post 1.15.

I also want to merge changes from #31 into the branch, but I think not have GSL_2_0_LATER guards around the code might break compatibility with previous GSL versions. @boutil could you please make the necessary changes ASAP?

@minad @blackwinter do you think this is fit for merging?

@minad
Copy link
Contributor

minad commented Mar 4, 2016

@v0dro Great! Concerning the commits, you could maybe split it into two bigger commits, one for the gsl2 compat and one for nmatrix? But if the rebasing would be too much effort it is not necessary.

@v0dro
Copy link
Member Author

v0dro commented Mar 4, 2016

It would be too much effort!

@minad
Copy link
Contributor

minad commented Mar 4, 2016

Ok but for the future I recommend that you work on separate branches if you do separate things. makes it easier in the long run when one inspects the git history. But not a big deal for now :)

@v0dro
Copy link
Member Author

v0dro commented Mar 4, 2016

Alright will do. Should I merge these changes?

Also, will it be possible for you to test this yourself by cloning my branch just to make sure that everything is working fine?

v0dro added a commit that referenced this pull request Mar 8, 2016
@v0dro v0dro merged commit 1f8e994 into SciRuby:master Mar 8, 2016
@v0dro
Copy link
Member Author

v0dro commented Mar 8, 2016

@minad could you release a new version on rubygems?

@v0dro
Copy link
Member Author

v0dro commented Mar 10, 2016

@minad could you release a new version?

@minad
Copy link
Contributor

minad commented Mar 11, 2016

@v0dro I added you as a owner of the gsl gem :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants