-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nmatrix compatibility #33
Conversation
…ents. Added verbosity to examples.
…r nmatrix and updated existing README with nmatrix how-tos.
@blackwinter could you also have a look? |
d59e47d
to
243c3dc
Compare
Quite a lot of code. Did you add nmatrix support to all the places where an narray could be used? |
243c3dc
to
9c98a65
Compare
Yep. Also made some optimizations here n there. Also, creating NArray views from GSL objects was causing GC problems so views will not be supported by NMatrix. |
5af7eac
to
19717b1
Compare
19717b1
to
abd9700
Compare
I'll be adding GSL 2.0 support next. Any suggestions? |
@ktns I have merged your GSL 2.1 changes from #30 for compatibility with GSL 2.1. I'm happy to say that rb-gsl is now comfortably working with all GSL versions post 1.15. I also want to merge changes from #31 into the branch, but I think not have @minad @blackwinter do you think this is fit for merging? |
@v0dro Great! Concerning the commits, you could maybe split it into two bigger commits, one for the gsl2 compat and one for nmatrix? But if the rebasing would be too much effort it is not necessary. |
It would be too much effort! |
Ok but for the future I recommend that you work on separate branches if you do separate things. makes it easier in the long run when one inspects the git history. But not a big deal for now :) |
Alright will do. Should I merge these changes? Also, will it be possible for you to test this yourself by cloning my branch just to make sure that everything is working fine? |
@minad could you release a new version on rubygems? |
@minad could you release a new version? |
@v0dro I added you as a owner of the gsl gem :) |
@minad this makes rb-gsl compatible with both nmatrix and narray. Request review.
Will add GSL 2.0 functionality soon.