Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gsl-2.1 breaks rb-gsl #24

Closed
0-wiz-0 opened this issue Nov 21, 2015 · 2 comments · May be fixed by #31
Closed

gsl-2.1 breaks rb-gsl #24

0-wiz-0 opened this issue Nov 21, 2015 · 2 comments · May be fixed by #31
Labels
bug

Comments

@0-wiz-0
Copy link

0-wiz-0 commented Nov 21, 2015

The latest rb-gsl release does not build against the current gsl 2.1 release. I see:

histogram.c: In function 'rb_gsl_histogram_fit_gaussian':
histogram.c:1222:23: error: 'gsl_multifit_fdfsolver' has no member named 'J'
   gsl_multifit_covar(s->J, 0.0, covar);
                       ^
histogram.c: In function 'rb_gsl_histogram_fit_rayleigh':
histogram.c:1356:23: error: 'gsl_multifit_fdfsolver' has no member named 'J'
   gsl_multifit_covar(s->J, 0.0, covar);
                       ^
histogram.c: In function 'rb_gsl_histogram_fit_xexponential':
histogram.c:1492:23: error: 'gsl_multifit_fdfsolver' has no member named 'J'
   gsl_multifit_covar(s->J, 0.0, covar);
                       ^
@v0dro v0dro added the bug label Nov 22, 2015
@v0dro v0dro mentioned this issue Nov 22, 2015
Closed
@ian-abbott
Copy link

There are also some warnings when compiling sf_ellint.c due to unused argument n (argument 3) being removed from gsl_sf_ellint_D() and gsl_sf_ellint_D_e() in GSL 2:

compiling ../../../../ext/gsl_native/sf_ellint.c
../../../../ext/gsl_native/sf_ellint.c: In function ‘rb_gsl_sf_ellint_D’:
../../../../ext/gsl_native/sf_ellint.c:85:37: warning: passing argument 1 of ‘rb_gsl_sf_eval_double3_m’ from incompatible pointer type [-Wincompatible-pointer-types]
     return rb_gsl_sf_eval_double3_m(gsl_sf_ellint_D, argv[0], argv[1], argv[2],
                                     ^
In file included from ../../../../ext/gsl_native/sf_ellint.c:13:0:
../../../../ext/gsl_native/include/rb_gsl_sf.h:58:7: note: expected ‘double (*)(double,  double,  double,  gsl_mode_t) {aka double (*)(double,  double,  double,  unsigned int)}’ but argument is of type ‘double (*)(double,  double,  gsl_mode_t) {aka double (*)(double,  double,  unsigned int)}’
 VALUE rb_gsl_sf_eval_double3_m(double (*func)(double, double, double, gsl_mode_t),
       ^
../../../../ext/gsl_native/sf_ellint.c:88:37: warning: passing argument 1 of ‘rb_gsl_sf_eval_double3_m’ from incompatible pointer type [-Wincompatible-pointer-types]
     return rb_gsl_sf_eval_double3_m(gsl_sf_ellint_D, argv[0], argv[1], argv[2],
                                     ^
In file included from ../../../../ext/gsl_native/sf_ellint.c:13:0:
../../../../ext/gsl_native/include/rb_gsl_sf.h:58:7: note: expected ‘double (*)(double,  double,  double,  gsl_mode_t) {aka double (*)(double,  double,  double,  unsigned int)}’ but argument is of type ‘double (*)(double,  double,  gsl_mode_t) {aka double (*)(double,  double,  unsigned int)}’
 VALUE rb_gsl_sf_eval_double3_m(double (*func)(double, double, double, gsl_mode_t),
       ^
../../../../ext/gsl_native/sf_ellint.c: In function ‘rb_gsl_sf_ellint_D_e’:
../../../../ext/gsl_native/sf_ellint.c:95:37: warning: passing argument 1 of ‘rb_gsl_sf_eval_e_double3_m’ from incompatible pointer type [-Wincompatible-pointer-types]
   return rb_gsl_sf_eval_e_double3_m(gsl_sf_ellint_D_e, phi, k, n, m);
                                     ^
In file included from ../../../../ext/gsl_native/sf_ellint.c:13:0:
../../../../ext/gsl_native/include/rb_gsl_sf.h:54:7: note: expected ‘int (*)(double,  double,  double,  gsl_mode_t,  gsl_sf_result *) {aka int (*)(double,  double,  double,  unsigned int,  struct gsl_sf_result_struct *)}’ but argument is of type ‘int (*)(double,  double,  gsl_mode_t,  gsl_sf_result *) {aka int (*)(double,  double,  unsigned int,  struct gsl_sf_result_struct *)}’
 VALUE rb_gsl_sf_eval_e_double3_m(int (*func)(double, double, double, gsl_mode_t, gsl_sf_result*),
       ^

@boutil boutil mentioned this issue Feb 29, 2016
Open
@v0dro
Copy link
Member

v0dro commented Mar 11, 2016

New gsl 2.1.0 has been released.

@v0dro v0dro closed this as completed Mar 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adapt to GSL 2.0 boutil/rb-gsl
3 participants
@ian-abbott @0-wiz-0 @v0dro