Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented pretty_print, to_a for dimension = 2 #13

Closed
wants to merge 2 commits into from
Closed

Implemented pretty_print, to_a for dimension = 2 #13

wants to merge 2 commits into from

Conversation

Uditgulati
Copy link
Member

Issue -> #6

@Uditgulati
Copy link
Member Author

@prasunanand The C API returns only a flat list of elements, so in order to traverse each row or column, I used incrementing of index. Let me know if there is some better way.

Also, are there any other functions that needs to be implemented with them?

@prasunanand
Copy link
Member

prasunanand commented Mar 19, 2019 •
edited
Loading

You need to implement indexers for n dimension.

@Uditgulati
Copy link
Member Author

@prasunanand Can you provide an example on how indexers for n dimension should look like or maybe some reference material for it?

@prasunanand
Copy link
Member

This would be a GSoC task.

@Uditgulati
Copy link
Member Author

Ok, thanks. Anything else required for this PR?

@Uditgulati
Copy link
Member Author

Updated to #36

@Uditgulati Uditgulati closed this Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Uditgulati @prasunanand