add serialization #56
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pkspyder007 CI is failing. Can you debug ? |
|
@prasunanand According to my checking ,CI is failing due to the bundler version compatibility. Adding a Gemlock file similar to package.lock in npm should lock all the version of gems and bundler we are using. |
|
@prasunanand If I add the Gemfile.lock the 5th test passes but the travis CI build fails and on removing Gemfile.lock the 5th test fails. You can see the result here |
|
@prasunanand @Uditgulati Any updates on this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added serialization for NMatrix class using Marshal module and custom implementation of load and dump functions.
Default Marshal serialization methods threw error so We needed to create our own serialization/deserialization strategies.
nm_int is the default fallback for dtype if it's not nm_float64 or nm_bool
Closes #35
(Explain how this PR changes numruby.)
This PR adds the ability for NMatrix to serialize the class objects which can be used to store the data in a file for future and to pass it between different processes and to be utilized
Test Plan
the test is written for comparing the original object and the one after serialization and deserialization
it checks for nm_float64, nm_int, and nm_bool dtypes