Preparing for release of 0.2.4. #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MohawkJohn, I agree with the changes. The Rakefile and Readme are no longer needed. Yes, |
translunar
added a commit
that referenced
this pull request
Dec 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did some basic cleanup and updated the Manifest. I need @prasunanand to sign off on these changes. In particular, I deleted the empty
README.mdfrom the Java extension. is theRakefilestill needed here, or does it now rely entirely on the root Rakefile? There is also one empty.javafile,ext/nmatrix_java/nmatrix/data/Complex.java. Can that be deleted?I also deleted a couple of scripts which I don't believe are used anymore, and moved the
ttable_helper.rbinto scripts, since it's not really part of the sources — just a generator.