Made templates a little smarter for those functions which require a s… #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wlevine Any chance you can take a look at this? Running into some problems with the extensions, since I don't have a working installation of ATLAS on my machine. |
| @@ -149,9 +149,9 @@ inline void cblas_asum(const int N, const void* X, const int incX, void* sum) { | |||
| * complex64 -> float or double | |||
| * complex128 -> double | |||
| */ | |||
| template <typename ReturnDType, typename DType> | |||
| template <typename DType, typename MDType = typename MagnitudeDType<DType>::type> | |||
| inline ReturnDType nrm2(const int N, const DType* X, const int incX) { | |||
|
Also, the template tables for cblas_nrm2 need updating in math_lapacke.cpp, math_atlas.cpp (and also math.cpp though somehow this one is compiling already?) |
…eparate return DType by adding MagnitudeDType. Also added a magnitude function to replace std::abs and abs -- but mostly it just calls those.
translunar
force-pushed
the
magnitude_dtype
branch
from
5b4120b
to
56f6eae
Compare
|
@v0dro Mind merging? Trying to follow the same rules I've asked other maintainers to follow. =) Looks like the failure is just a Travis problem. |
|
works. looks good :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The return dtype for functions that return a magnitude doesn't need to be specified any longer.