Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rdoc and json are incompatible #553

Open
isuruf opened this issue Oct 20, 2016 · 8 comments
Open

rdoc and json are incompatible #553

isuruf opened this issue Oct 20, 2016 · 8 comments
Labels

Comments

@isuruf
Copy link

isuruf commented Oct 20, 2016

rdoc needs json ~> 1.4 (>=1.4, < 2.0) and nmatrix requires >= 2.0.1.

@translunar
Copy link
Member

I believe I just put in ~> 2.0.1 because that's the one I got working at the time. Do you want to see what happens in your PR if you change it to 1.4?

@isuruf
Copy link
Author

isuruf commented Oct 20, 2016

I just did, and it fails to install json 1.8.3. json needs to be updated to 2.0.1 to build with the latest ruby version. So, I guess this is an issue with rdoc

@isuruf
Copy link
Author

isuruf commented Oct 20, 2016

Problem is that with ruby 2.4.0-dev, this is checked strictly. Earlier when ruby 2.0.1 was installed it was okay even if rdoc needed < 2.0. Now it is enforced and therefore fails.

@translunar
Copy link
Member

Is this the problem?

ruby/json#303

It looks like we can just drop the json requirement altogether, yes?

@isuruf
Copy link
Author

isuruf commented Oct 20, 2016

Yes, it is. Dropping the json requirement won't help, since rdoc has json as a requirement.

@isuruf
Copy link
Author

isuruf commented Oct 20, 2016

Dropping the requirement will help ruby versions < 2.4

@translunar
Copy link
Member

Looks like we need RDoc 5.

https://github.com/rdoc/rdoc/pull/412

@translunar translunar added the bug label Oct 21, 2016
@translunar
Copy link
Member

Possibly related to #606?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants