Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve array and matrix display speed #197

Closed
kojix2 opened this issue Apr 17, 2019 · 10 comments · Fixed by #255
Closed

Improve array and matrix display speed #197

kojix2 opened this issue Apr 17, 2019 · 10 comments · Fixed by #255

Comments

@kojix2
Copy link
Member

kojix2 commented Apr 17, 2019

It may be time to rethink how iRuby displays arrays.

Matrix rendering with MathJax is beautiful. However, it is not appropriate when displaying large sized arrays or matrices. In the worst case, the browser freezes.

ruby-numo/numo-narray#124

@kojix2
Copy link
Member Author

kojix2 commented Apr 19, 2019

@zalt50 What do you think?

@prasunanand
Copy link
Member

Cc @Uditgulati

@zalt50
Copy link
Contributor

zalt50 commented Apr 22, 2019

How about c2d55563a3a5ead26af02bb5b3b3ea1c3e0b3352? It makes an array clipped.
clipped array

@kojix2
Copy link
Member Author

kojix2 commented Apr 23, 2019

I see.
I think it's very good.
I want to display the last number of each line/column if possible.

@mrkn
Copy link
Contributor

mrkn commented Apr 25, 2019

I want to stop implicit use of MathJax for displaying the result.

@kojix2
Copy link
Member Author

kojix2 commented Apr 29, 2019

@prasunanand
Thank you .I am a fan of NArray.
Let me know if you have any feedback from NMatrix community.

@mrkn
I agree.

@zalt50 How about kojix2@b3f7ddc

image

@Uditgulati
Copy link
Member

I think only showing first 5 and last rows and columns should be enough.

We are thinking of fixing this problem for NMatrix too during this GSoC.

@zalt50
Copy link
Contributor

zalt50 commented Apr 30, 2019

kojix2@b3f7ddc is nice for me, but some people don't need MathJax so is it possible to choose whether to use MathJax in runtime?

@kojix2
Copy link
Member Author

kojix2 commented Aug 9, 2019

Oops, It was discussed in the past #97

@kojix2
Copy link
Member Author

kojix2 commented Oct 20, 2019

Changed default display format for NArray to text/plain.
Thanks to everyone who commented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants