Insert column data at specified location #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- new method insert_vector - added specs
| expect(subject).to eq df | ||
| end | ||
|
|
||
| it "raises error for data array being too big" do |
| }.to raise_error(IndexError) | ||
| end | ||
|
|
||
| it "raises error for invalid index value" do |
| }.to raise_error(ArgumentError) | ||
| end | ||
|
|
||
| it "raises error for invalid source type" do |
There was a problem hiding this comment.
It would be better to provide some message/hint along with error, so that user can fix it error .
| @@ -545,6 +545,17 @@ def add_vector n, vector | |||
| self[n] = vector | |||
| end | |||
|
|
|||
| def insert_vector n, name, source | |||
There was a problem hiding this comment.
-
Why it is always necessary to provide name of the index ?
-
Please make the argument names clearly like: use
nthColumninstead ofn
| @@ -545,6 +545,17 @@ def add_vector n, vector | |||
| self[n] = vector | |||
| end | |||
|
|
|||
| def insert_vector n, name, source | |||
| raise ArgumentError unless source.is_a? Array | |||
| vector = Daru::Vector.new(source, index: @index, name: @name) | |||
There was a problem hiding this comment.
Can we have choice to pass vector directly to be inserted (think about other ways as well)?
| raise ArgumentError unless source.is_a? Array | ||
| vector = Daru::Vector.new(source, index: @index, name: @name) | ||
| @data << vector | ||
| @vectors = @vectors.add name |
There was a problem hiding this comment.
Can't we do @vectors = @vectors.insert(n, name) simply?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to resolve issue #507