Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix table style #489

Merged
merged 1 commit into from
Mar 1, 2019
Merged

fix table style #489

merged 1 commit into from
Mar 1, 2019

Conversation

kojix2
Copy link
Member

@kojix2 kojix2 commented Feb 18, 2019

Improve the appearance of the table.

I am running IRuby & Daru on Google Colab. Google Colab officially supports Python. But Ruby works.

The dataframe style is not adapted to the table.

<table></table>

image

After adding the dataframe class to the table tag, Daru::DataFrame looks better.

This is as same as Pandas.

<table border="1" class="dataframe"></table>

image

I hope the Google Colab team officially support the IRuby kernel someday. Therefore, I think that such minor change in appearance is more important than expected.

Copy link
Member

@Shekharrajak Shekharrajak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please try examples present in this notebook as well ?

@kojix2
Copy link
Member Author

kojix2 commented Feb 28, 2019

I tried it.
The notebook example seems to be OK.

https://nbviewer.jupyter.org/gist/kojix2/986aef56aedcbfb59be3283a886457cf

image

@Shekharrajak
Copy link
Member

Thanks @kojix2 , It will be merged after the travis error is sovled.

@Shekharrajak Shekharrajak merged commit 940fe7e into SciRuby:master Mar 1, 2019
@kojix2 kojix2 deleted the table_style branch March 2, 2019 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants