Multiple charts in a row #97

Prakriti-nith · 2018-06-15T12:02:19Z

This feature provides the facility to visualize multiple google charts in a single cell in IRuby notebook and in a single row in web frameworks. Examples link.

Added docs

Prakriti-nith · 2018-07-03T01:01:01Z

Updated examples. I have added id as a parameter to plot object as it was required in PlotList class. I will add the tests shortly.

Prakriti-nith · 2018-07-03T20:12:19Z

Now, multiple charts can be shown with googlecharts, google datatables, highcharts and nyaplot. Updated examples.

coveralls · 2018-07-06T22:30:27Z

Pull Request Test Coverage Report for Build 600

108 of 113 (95.58%) changed or added relevant lines in 4 files are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.4%) to 96.512%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
lib/daru/view/adapters/highcharts/display.rb	0	1	0.0%
spec/plot_list_spec.rb	60	61	98.36%
lib/daru/view/plot_list.rb	47	50	94.0%

Files with Coverage Reduction	New Missed Lines	%
lib/daru/view/adapters/highcharts/display.rb	4	90.91%

Totals
Change from base Build 578:	0.4%
Covered Lines:	2075
Relevant Lines:	2150

💛 - Coveralls

Prakriti-nith · 2018-07-12T00:01:43Z

@Shekharrajak can you please review the changes?

Shekharrajak

Please include more than 2 charts in IRuby examples.

Shekharrajak · 2018-07-12T09:29:04Z

lib/daru/view/plot_list.rb

-                                     plot.is_a?(Daru::View::Plot) ||
-                                     plot.is_a?(Daru::View::Table)
-                                   }
+        raise ArgumentError, 'Invalid Argument Passed!' unless


Also write what are the valid parameter types.

Shekharrajak · 2018-07-12T09:29:39Z

lib/daru/view/plot_list.rb

@@ -4,7 +4,7 @@
 require 'daru/view/adapters/googlecharts/display'

 # Otherwise Daru::IRuby module was used and IRuby.html method was not working.
-
+# Have disabled rubocop Style/Mixin for this in .rubocop.yml file


Once it is merged , then open the issue for it. So that we can keep track to solve it.

Shekharrajak · 2018-07-12T09:31:03Z

.rubocop.yml

@@ -17,7 +17,7 @@ AllCops:
    - 'daru-view.gemspec'
    - '**/*.rake'
  DisplayCopNames: true
-  TargetRubyVersion: 2.1
+  TargetRubyVersion: 2.2


Why this change?

Updated target ruby version to 2.2 in .rubocoop.yml file as rubocop was producing this error:

Error: Unsupported Ruby version 2.1 found in TargetRubyVersion parameter (in .rubocop.yml). 2.1-compatible analysis was dropped after version 0.58.

Shekharrajak · 2018-07-12T09:50:47Z

lib/daru/view/plot_list.rb

+        charts_script = ''
+        @data.each do |plot|
+          chart_script = extract_chart_script(plot)
+          charts_div_tag << chart_script.partition(%r{<div(.*?)<\/div>}ixm)[1]


It's name must be chart_id_div_tag or something that tell about the value it contains.

Shekharrajak · 2018-07-12T09:51:49Z

lib/daru/view/plot_list.rb

+        # TODO: Implement this for datatables too
+        return plot.div unless defined?(IRuby.html) &&
+                               plot.is_a?(Daru::View::Plot) &&
+                               plot.chart.is_a?(LazyHighCharts::HighChart)


Why do we need to check HighCharts explicitly ?

In HighCharts, js for web frameworks (includes onload) and IRuby notebook is generated separately. So, plot.div would generate the wrong script for HighCharts in case of IRuby notebook. That's why I have checked it separately.

Shekharrajak · 2018-07-12T09:54:48Z

lib/daru/view/adapters/highcharts/display.rb

@@ -89,6 +88,7 @@ def show_in_iruby(placeholder=random_canvas_id)
    # `high_chart_iruby` which doesn't use `onload` in chart script.
    def to_html_iruby(placeholder=random_canvas_id)
      # TODO : placeholder pass, in plot#div
+      load_dependencies('iruby')


to_html_iruby is for generating the html and javascript only. At that time will don't want to load the dependent files, right ?

load_dependecies is used to load the dependencies for HighCharts modules (provided in the modules option) and HighMaps dependent files. Right now, in web frameworks too, these dependencies are loaded in to_html.

Okay in this case we have to load it during the generation of body html code.

Shekharrajak · 2018-07-12T10:00:42Z

spec/plot_list_spec.rb

+      expect(content).to match(/window.addEventListener\('load_nyaplot', render/)
+    end
+  end
+end


new line here

Shekharrajak · 2018-07-12T10:02:49Z

lib/daru/view/templates/multiple_charts_div.erb

@@ -0,0 +1,8 @@
+<table class='columns'>


class='columns' is for ?

Shekharrajak · 2018-07-12T10:04:05Z

spec/plot_list_spec.rb

+    subject (:js) { combined.div }
+    it 'generates a table in js' do
+      expect(js).to match(/<table class='columns'>/)
+      expect(js).to match(/<td><div id=/)


check 4 times <div id= . It would be better if we can test the custom id, that was passed as well.

Shekharrajak · 2018-07-12T10:04:51Z

spec/plot_list_spec.rb

+      expect(js).to match(/<td><div id=/)
+    end
+    context 'when js of the plots is generated' do
+      it 'generates js of googlecharts' do


Please check the data and other tags , if required as well.

Shekharrajak · 2018-07-12T10:08:14Z

Also commit after running IRUby examples.

Multiple charts in a row

0d75e8e

Added docs

Prakriti-nith force-pushed the multiple_googlecharts branch from 14efb07 to 0d75e8e Compare June 16, 2018 12:31

Prakriti-nith added 2 commits June 16, 2018 18:07

Resolve errors

e456894

Added tests

a291110

Prakriti-nith force-pushed the multiple_googlecharts branch from 2e662f8 to a291110 Compare June 17, 2018 15:25

Prakriti-nith added 2 commits June 24, 2018 07:41

Add PlotList class

759b218

Add plot_list_specs.rb

132cbf6

Prakriti-nith force-pushed the multiple_googlecharts branch from 4a9d9bc to 132cbf6 Compare June 27, 2018 03:10

Updated implementation

3f2c9a2

Prakriti-nith force-pushed the multiple_googlecharts branch from d6c9c61 to 3f2c9a2 Compare July 2, 2018 21:02

include IRuby::Utils to make it work for IRuby notebook

3bf1399

Prakriti-nith added 4 commits July 3, 2018 10:33

Added export_html_file method

6a2d31d

Added support for nyaplot and updated implementation

20dfdf4

Updated docs

2671cd7

Updated examples

7de361b

Prakriti-nith added 2 commits July 7, 2018 00:06

Removed tests for to_html_iruby in highcharts

027b79d

Merge branch 'master' into multiple_googlecharts

5253623

Add Style/Mixin to .rubocop.yml

3e18eef

Prakriti-nith force-pushed the multiple_googlecharts branch from 77ca735 to 3e18eef Compare July 8, 2018 06:37

Prakriti-nith added 2 commits July 11, 2018 05:06

Updated examples

0688924

Update TargetRubyVersion to 2.2

4bbbddf

Shekharrajak reviewed Jul 12, 2018

View reviewed changes

Updated examples and tests

e58a7e6

Shekharrajak approved these changes Jul 13, 2018

View reviewed changes

Shekharrajak merged commit 2a62667 into SciRuby:master Jul 13, 2018

Shekharrajak mentioned this pull request Jul 13, 2018

Examples for PlotList Shekharrajak/demo_daru-view#7

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Multiple charts in a row #97

Multiple charts in a row #97

Prakriti-nith commented Jun 15, 2018 •

edited

Loading

Prakriti-nith commented Jul 3, 2018

Prakriti-nith commented Jul 3, 2018 •

edited

Loading

coveralls commented Jul 6, 2018 •

edited

Loading

Prakriti-nith commented Jul 12, 2018

Shekharrajak left a comment

Shekharrajak Jul 12, 2018

Shekharrajak Jul 12, 2018

Prakriti-nith Jul 12, 2018

Shekharrajak Jul 12, 2018

Prakriti-nith Jul 12, 2018

Shekharrajak Jul 12, 2018

Shekharrajak Jul 12, 2018

Prakriti-nith Jul 12, 2018

Shekharrajak Jul 12, 2018

Prakriti-nith Jul 12, 2018

Shekharrajak Jul 13, 2018

Shekharrajak Jul 12, 2018

Shekharrajak Jul 12, 2018

Shekharrajak Jul 12, 2018

Shekharrajak Jul 12, 2018

Shekharrajak commented Jul 12, 2018

Multiple charts in a row #97

Multiple charts in a row #97

Conversation

Prakriti-nith commented Jun 15, 2018 • edited Loading

Prakriti-nith commented Jul 3, 2018

Prakriti-nith commented Jul 3, 2018 • edited Loading

coveralls commented Jul 6, 2018 • edited Loading

Pull Request Test Coverage Report for Build 600

💛 - Coveralls

Prakriti-nith commented Jul 12, 2018

Shekharrajak left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Shekharrajak commented Jul 12, 2018

Prakriti-nith commented Jun 15, 2018 •

edited

Loading

Prakriti-nith commented Jul 3, 2018 •

edited

Loading

coveralls commented Jul 6, 2018 •

edited

Loading