Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed the duplicate highcharts.css #145

Merged
merged 2 commits into from
Feb 24, 2019
Merged

Conversation

snpd25
Copy link
Contributor

@snpd25 snpd25 commented Feb 16, 2019

References to other Issues or PRs

Fixes #128

@coveralls
Copy link

Pull Request Test Coverage Report for Build 782

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.005%) to 98.118%

Totals Coverage Status
Change from base Build 780: -0.005%
Covered Lines: 3128
Relevant Lines: 3188

💛 - Coveralls

@Shekharrajak
Copy link
Member

Hi @snpd25 , can you please run all the examples in IRuby notebook (specs/dummy_iruby) and check to make sure whether it is fine or not (you don't need to commit those)?

Thanks for the PR!

@snpd25
Copy link
Contributor Author

snpd25 commented Feb 18, 2019

I have run all the examples in IRuby Notebook, and found these issue: #130 and #146 . Rest everything was working fine.

@Shekharrajak
Copy link
Member

@snpd25 , Thanks for update.

I have run all the examples in IRuby Notebook, and found these issue: #130 and #146 . Rest everything was working fine.

I have already replied to query in #130 , I don't know what problem you are facing.

I personally feel that you should mention the things/query properly.

@snpd25
Copy link
Contributor Author

snpd25 commented Feb 21, 2019

@Shekharrajak , sorry for the inconvenience, I commented the problem there. But I feel that these issues do not rise due to the removal of the highcharts.css file , as I checked the examples with having the duplicate file, and it worked the same.

@Shekharrajak Shekharrajak added this to the 0.2.5 milestone Feb 24, 2019
Copy link
Member

@Shekharrajak Shekharrajak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Shekharrajak Shekharrajak merged commit 45e17ca into SciRuby:master Feb 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants