-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated API, added tests, docs, export_html method and generate_html method #104
Conversation
5ed41b4
to
2441a21
Compare
This PR runs in parallel with changes in daru-data_tables#20. Those changes are not reflected here and will be seen after that PR gets merged. So some of the test cases failed due to that. |
I have updated the implementation to load a large set of data here. As the changes are in parallel in both the PRs, some of the tests will not pass. |
I haven't added tests for generate_html as generate_html and export_html_file will then have the redundant tests. I am adding the tests for to_html in daru-data_tables. |
9234195
to
e9311ef
Compare
Pull Request Test Coverage Report for Build 609
💛 - Coveralls |
e9311ef
to
035f9fd
Compare
9e98c56
to
d523244
Compare
We should have testcases calling datatables adaptor here as well. |
@Shekharrajak I have added the test cases in this PR also. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Please write examples and update the Wiki page accordingly.
Thanks!
Right now, data is converted in the form of html table. I have shifted it to javascript array for the further server-side implementation (as datatable can take Array of Array). I will execute the server-side implementation (to load large set of data piece by piece) in this PR too. Parallel changes will be done accordingly in daru-datable in a separate PR.
I am also trying to resolve this issue. In this PR data is set correctly in the javascript array but the column names are overlapping for multiple tables.