Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JS files for the libraries #47

Open
Shekharrajak opened this issue Aug 2, 2017 · 8 comments
Open

Update JS files for the libraries #47

Shekharrajak opened this issue Aug 2, 2017 · 8 comments

Comments

@Shekharrajak
Copy link
Member

Developers can update the js files using these command in the repo:

rake library_name:update

e.g. rake highcharts:update

To update all the JS files : rake update_all

But how user will update it (who have installed the gem from the source or using gem install) ?

Probably we can have CLI and using command daur-view update_js library_name user can update the particular js . I like the way Thor gem works. But there is some other good Command Line Interface Gems as well.

@rohitner
Copy link
Contributor

rohitner commented Mar 4, 2018

I think we should use ARGV because the gem is less likely to get CLI intensive in future. WDYT?

@rohitner
Copy link
Contributor

rohitner commented Mar 7, 2018

ping! @Shekharrajak I would like to take up this issue

@Shekharrajak
Copy link
Member Author

@rohitner , sorry for late response! Yes , we didn't think much about CLI in daru-view. But to update the js files, calling method don't look a good choice to me. I am not sure about it. Can you light more on your idea?

@zverok , what do you think?

@Shekharrajak
Copy link
Member Author

@rohitner , meanwhile you can open PR with your idea.

@rohitner
Copy link
Contributor

rohitner commented Mar 8, 2018

We can also make use of optparse module like that being done by the gem colorls (although Thor has advantages like seperate parsers for different commands). I think OptionParse class will be most appropriate at this point.

@zverok
Copy link
Collaborator

zverok commented Mar 8, 2018

@rohitner

I think we should use ARGV because the gem is less likely to get CLI intensive in future.

I am not sure what do you mean, can you please elaborate?

@rohitner
Copy link
Contributor

rohitner commented Mar 9, 2018

I mean to say that using pre-installed modules like optparse are enough for supporting a few command line arguments rather than adding third-party dependencies like Thor.

@Shekharrajak
Copy link
Member Author

Pending work after PR #83

#83 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants