Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy example notebooks to sciruby-notebooks? #137

Open
lokeshh opened this issue Jan 19, 2019 · 1 comment
Open

Copy example notebooks to sciruby-notebooks? #137

lokeshh opened this issue Jan 19, 2019 · 1 comment

Comments

@lokeshh
Copy link
Member

lokeshh commented Jan 19, 2019

I'm thinking about copying the example notebooks to https://github.com/sciruby/sciruby-notebooks repository because it supports interaction with them via https://mybinder.org/. Is that a good idea?

@Shekharrajak
Copy link
Member

Thanks @lokeshh for sharing this. It look a good idea to have all the SciRuby gem example in one place.

There are test cases written for almost all the chart generator , but whenever changes happen (mostly in JS code generator method ) in daru-view repo, I prefer to run corresponding examples present in spec/dummy_iruby (IRuby notebook files) and update them all with new changes (which checks the latest code changes).

So we can have totally new real world examples to add in https://github.com/sciruby/sciruby-notebooks and examples present in daru-view/spec/dummy_iruby will remain same.

And/Or

we can have a folder in https://github.com/sciruby/sciruby-notebooks for visualization , that will refer https://github.com/SciRuby/daru-view/tree/master/spec/dummy_iruby .

Let me know if you have any better suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants