Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SBML Test-Suite Results Tracker #45

Open
anandijain opened this issue Oct 25, 2021 · 7 comments
Open

SBML Test-Suite Results Tracker #45

anandijain opened this issue Oct 25, 2021 · 7 comments

Comments

@anandijain
Copy link
Contributor

anandijain commented Oct 25, 2021

SBML test suite report

SBMLtoolkit.jl is regularly tested against the SBML test suite. The last test was run on October 24, 2021 on cases 00001 to 01664. Detailed results can be found in the csv below. Out of the 1664 cases 1219 expectedly failed, as

  • they contain SBML constraints, rules or events, or
  • do not contain any reactions, or
  • cannot be converted to SBML Version 3 Level 2, or
  • contain kineticLaws in reversible reactions with ambiguous forward and reverse part, or
  • are flux balance models.

Of the remaining 445 cases

  • 422 can be converted to a ModelingToolkit.ReactionSystem, of which
  • 416 simulate without returning an error, of which
  • 416 yield the correct simulation results.

CSV

test_suite_report.csv

@matthiaskoenig
Copy link

matthiaskoenig commented Oct 25, 2021

You should submit the results on the official webpage. This allows people to easily evaluate what can be simulated.
See here for the database: http://raterule.caltech.edu/Facilities/Database
And here for an example: http://raterule.caltech.edu/Facilities/Database/Submission/Details/281

edit: fixed links

@anandijain
Copy link
Contributor Author

@matthiaskoenig both of those 404

@matthiaskoenig
Copy link

@matthiaskoenig
Copy link

Hi all,
I want to use SBMLToolkit but would need some way to see what is currently supported/failing to see if it makes sense to use the library or it is simpler to use own converters of mine to get the models in Julia.

How can I run the SBMLTestSuite? Where is the code which generates the test_suite_report.csv so I can run it on the latest release/develop branch? I would be especially interested in support of rules/events/delays. If most of what I need is already supported I would like to add support for missing pieces.

Best Matthias

@paulflang
Copy link
Member

Hi Matthias, here is a link to a recent SBMLToolkitTestSuite run and the code that generates it. I wanted to upload these results to http://raterule.caltech.edu/Facilities/Database a long time ago, but the website is still down. Do you know if the database has been moved elsewhere?

Rules should be supported, events only partially (i.e. they always fire regardless of direction of the trigger pass - the user is warned of this behaviour), and delays not at all. I also have to admit, I haven't had time to properly look at the test suite cases since three years and we haven't set up a system to check for regression (beyond of what is implemented in the SBMLToolkit repo tests itself). I am sure you are familiar of using SBMLImporter as an alternative.

I haven't looked into delays, but for a long time, event directionality was not supported by Catalyst and therefore not by SBMLToolkit. @TorkelE I forgot where we stand on this issue atm. Once implemented in Catalyst, it is probably just this line that would have to be modified in SBMLToolkit.

@TorkelE
Copy link
Member

TorkelE commented Dec 10, 2024

So I think directional events should now be supported within MTK, so we could be able to use them in Catalyst. But I have since then forgotten what the progress was and if it was supported in principle or it was fully ready. Sebastian probably knows.

@ChrisRackauckas
Copy link
Member

They are in MTK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants