From a1fbe81cd6b102ed65931133c8985bafadc89709 Mon Sep 17 00:00:00 2001 From: YingboMa Date: Sun, 22 Jul 2018 14:36:55 -0700 Subject: [PATCH] Fix #9 --- src/MuladdMacro.jl | 68 ++++++++++++++++++++++++++++++++-------------- 1 file changed, 48 insertions(+), 20 deletions(-) diff --git a/src/MuladdMacro.jl b/src/MuladdMacro.jl index 41f0d0b..a7e9d32 100644 --- a/src/MuladdMacro.jl +++ b/src/MuladdMacro.jl @@ -1,6 +1,7 @@ +__precompile__(true) module MuladdMacro -using MacroTools: postwalk, @capture +using MacroTools: postwalk """ @muladd @@ -68,7 +69,9 @@ Replace subtraction `ex` by `muladd` if possible. """ function sub_to_muladd(ex) # Retrieve operands - x, y = args(ex) + _x = args(ex) + length(_x) == 1 && return ex + x, y = _x # Modify subtraction if possible dotcall = isdotcall(ex) @@ -87,23 +90,32 @@ end Determine whether `ex` is a dot call. """ -isdotcall(ex) = - (@capture(ex, (f_)(__)) && startswith(string(f), '.')) || - @capture(ex, (_).(__)) +isdotcall(ex) = ex.head == :. || string(ex.args[1])[1] == '.' + +""" + iscall(ex, op) + +Determine whether `ex` is a call to `op`. +""" +function iscall(ex, op) + !(typeof(ex) <: Expr) && return false + _op = ex.args[1] + return _op == op || _op == Symbol(:., op) +end """ issum(ex) Determine whether `ex` is a sum. """ -issum(ex) = @capture(ex, +(__) | .+(__) | (+).(__)) +issum(ex) = iscall(ex, :+) """ issub(ex) Determine whether `ex` is a subtraction. """ -issub(ex) = @capture(ex, -(_, _) | .-(_, _) | (-).(_, _)) +issub(ex) = iscall(ex, :-) """ ismul(ex, dot::Bool) @@ -112,10 +124,12 @@ Determine whether expression `ex` is a multiplication that is dotted if `dot` is `true` and not dotted otherwise. """ function ismul(ex, dot::Bool) + !(typeof(ex) <: Expr) && return false if dot - return @capture(ex, .*(__) | (*).(__)) + return typeof(ex) <: Expr && + ( ex.args[1] == :.* || (ex.head == :. && ex.args[1] == :*) ) else - return @capture(ex, *(__)) + return typeof(ex) <: Expr && ex.args[1] == :* end end @@ -140,9 +154,17 @@ end Return arguments of function call in `ex`. """ function args(ex) - @capture(ex, (_)(x__) | (_).(x__)) || error("expression is not a function call") - - return x + if typeof(ex) <: Expr + if ex.head == :call + x = ex.args[2:end] + return x + end + if ex.head == :. + x = ex.args[2].args[1:end] + return x + end + end + error("expression is not a function call") end """ @@ -152,9 +174,17 @@ Split arguments of function call `ex` before last argument and combine first arguments to one expression if possible. """ function splitargs(ex) - @capture(ex, (_)(x__, y_) | (_).(x__, y_)) || error("cannot split arguments") - - return newargs(ex, x...), y + if ex.head == :call + x = ex.args[2:end-1] + y = ex.args[end] + return newargs(ex, x...), y + end + if ex.head == :. + x = ex.args[2].args[1:end-1] + y = ex.args[2].args[end] + return newargs(ex, x...), y + end + error("cannot split arguments") end """ @@ -168,13 +198,11 @@ argument is provided it is returned. function newargs(ex, args...) # Return single argument length(args) == 1 && return args[1] + f = ex.args[1] # Create function calls with new arguments - if @capture(ex, (f_)(__)) - return :($f($(args...))) - elseif @capture(ex, (f_).(__)) - return :(($f).($(args...))) - end + ex.head == :. && return :(($f).($(args...))) + ex.head == :call && return :(($f)($(args...))) error("expression is not a function call") end