Merge pull request #134 from SciML/gpu

Fix GPU exponential! defaults
SciML · Sep 9, 2023 · a2a45ae · a2a45ae
2 parents 887d7d5 + c449067
commit a2a45ae
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 0 deletions.
diff --git a/src/exp.jl b/src/exp.jl
@@ -13,6 +13,7 @@ end
 @deprecate _exp! exponential!
 @deprecate exp_generic exponential!
 exponential!(A) = exponential!(A, ExpMethodHigham2005(A));
+exponential!(A::GPUArraysCore.AbstractGPUArray) = exponential!(A, ExpMethodHigham2005(false));
 
 ## The diagonalization based
 """

diff --git a/src/exp_noalloc.jl b/src/exp_noalloc.jl
@@ -10,6 +10,7 @@ struct ExpMethodHigham2005
 end
 ExpMethodHigham2005(A::AbstractMatrix) = ExpMethodHigham2005(A isa StridedMatrix)
 ExpMethodHigham2005() = ExpMethodHigham2005(true)
+ExpMethodHigham2005(A::GPUArraysCore.AbstractGPUArray) = ExpMethodHigham2005(false)
 
 function alloc_mem(A, ::ExpMethodHigham2005)
     T = eltype(A)

diff --git a/test/gpu/gputests.jl b/test/gpu/gputests.jl
@@ -25,6 +25,8 @@ end
     eA = exp(A)
     A_d = cu(A)
 
+    exponential!(copy(A_d)) # Make sure simple command works
+
     # Iterate over GPU-compatible methods
     for m in (ExpMethodHigham2005(false),)
         @testset "GPU Exponential, $(string(m))" begin