fix unit test

Author: Junjiequan

src/app/shared/modules/filters/multiselect-filter.component.spec.ts

@@ -115,9 +115,8 @@ describe("MultiSelectFilterComponent", () => {
   describe("#itemSelected()", () => {
     it("should dispatch an AddMultiSelectFilterAction", () => {
       dispatchSpy = spyOn(component.selectionChange, "emit");
-
-      const value = "test";
-      component.itemSelected({ _id: value });
+      const value = { _id: "test" };
+      component.itemSelected(value);
 
       expect(dispatchSpy).toHaveBeenCalledTimes(1);
       expect(dispatchSpy).toHaveBeenCalledWith({
@@ -132,8 +131,8 @@ describe("MultiSelectFilterComponent", () => {
     it("should dispatch a RemoveMultiSelectFilterAction", () => {
       dispatchSpy = spyOn(component.selectionChange, "emit");
 
-      const value = "test";
-      component.itemRemoved(value);
+      const value = { _id: "test" };
+      component.itemRemoved("test");
 
       expect(dispatchSpy).toHaveBeenCalledTimes(1);
       expect(dispatchSpy).toHaveBeenCalledWith({

src/app/shared/modules/filters/multiselect-filter.component.ts

@@ -1,6 +1,6 @@
 import { Component, EventEmitter, Input, Output } from "@angular/core";
 import { createSuggestionObserver, getFacetCount } from "./utils";
-import { BehaviorSubject, Observable } from "rxjs";
+import { BehaviorSubject, Observable, of } from "rxjs";
 import { ClearableInputComponent } from "./clearable-input.component";
 import { AppConfigService } from "app-config.service";
 import { FacetCount } from "state-management/state/datasets.store";
@@ -22,8 +22,8 @@ export class MultiSelectFilterComponent extends ClearableInputComponent {
   @Input() key = "";
   @Input() label = "";
   @Input() tooltip = "";
-  @Input() facetCounts$: Observable<FacetCount[]>;
-  @Input() currentFilter$: Observable<string[]>;
+  @Input() facetCounts$: Observable<FacetCount[]> = of([]);
+  @Input() currentFilter$: Observable<string[]> = of([]);
   @Output() selectionChange = new EventEmitter<MultiSelectFilterValue>();
 
   appConfig = this.appConfigService.getConfig();
@@ -53,14 +53,17 @@ export class MultiSelectFilterComponent extends ClearableInputComponent {
   }
 
   itemSelected(value: { _id: string; label?: string } | null) {
-    this.selectionChange.emit({ key: this.key, value: value, event: "add" });
+    this.selectionChange.emit({ key: this.key, value, event: "add" });
     this.input$.next("");
   }
 
   itemRemoved(value: string | null) {
+    // This is workaround since the currentFilter$ only contains the id string
+    const valueObj = { _id: value };
+
     this.selectionChange.emit({
       key: this.key,
-      value: { _id: value },
+      value: valueObj,
       event: "remove",
     });
   }