Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream changes #6

Closed
Leon0402 opened this issue Oct 20, 2020 · 3 comments
Closed

Upstream changes #6

Leon0402 opened this issue Oct 20, 2020 · 3 comments
Labels
upstream This issue also exists in upstream

Comments

@Leon0402
Copy link

Hi,

would you consider upstreaming features? I do especially have chat bubbles in mind. It's a long open issue: element-hq/element-web#4635

Thanks! :)

@SpiritCroc
Copy link
Member

If the Element team is interested in it, I'm open to it. I'm not sure how their design process works, though.

The current implementation is not ready for this, as there are some layout bugs remaining, and the bubbles are hardcoded instead of providing a proper setting at the moment.

@Leon0402
Copy link
Author

Leon0402 commented Oct 20, 2020

I'm not sure either, it's just something very high on my personal wishlist for element and it would be great if it could made it way into element. I believe a lot of people would prefer not to have, so it would need to be configurable and perhaps off by default (you can then enable it here by default).

Edit: Btw. I just saw, you have also forks for android with useful changes. It's up to you, but I would encourage you to try to upstream more of these. The matrix community will profit the most from it this way.

@su-ex su-ex added the prio:low Low priority label Nov 30, 2020
@su-ex su-ex added upstream This issue also exists in upstream and removed prio:low Low priority labels Dec 16, 2020
@su-ex
Copy link
Member

su-ex commented Jan 30, 2021

Upstreaming the bubble layout is ongoing.
I already have and on occasion also will do pull requests for some other fixes/features.

@su-ex su-ex closed this as completed Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream This issue also exists in upstream
Projects
None yet
Development

No branches or pull requests

3 participants