Feature/metabase scalingo/csv plugin support #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-plugins' into feature/metabase-scalingo/csv_plugin_support
Add support for CSV driver plugin, thanks to @jdauphant See #8 Also updated `scalingo.json` and `README.md` files consequently.
johnsudaar
reviewed
Aug 10, 2022
| @@ -0,0 +1,35 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
It looks like you're trying to convert this repository to a buildpack. But this repository is not in the chain of buildpack (see .buildpacks file).
Plus wouldn't it be better to backport those changes into the metabase buildpack and not create a new one ?
There was a problem hiding this comment.
Ok, I didn't think this would be an issue. But I understand your point, closing for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the CSV driver plugin, thanks to @jdauphant.
Update the
scalingo.jsonandREADME.mdfiles consequently.Fixes #8