Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Donations and petitions Filters show when there are none values #98

Open
cdemeke opened this issue Jun 9, 2020 · 1 comment
Open

Donations and petitions Filters show when there are none values #98

cdemeke opened this issue Jun 9, 2020 · 1 comment

Comments

@cdemeke
Copy link
Member

cdemeke commented Jun 9, 2020

We currently show a filter on donations and petitions page however that filter shouldn't show if there are no values since it returns an empty page.

For example, right now if I filter based on "policy" on the petitions page, the page just returns a blank.
@charlyecastro
Copy link
Contributor

Maybe instead of removing the filters, we display an empty state illustration when there are no results. Similar to this image below. What do you think?

no-results-found

@Sharkesm Sharkesm mentioned this issue Jul 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cdemeke @charlyecastro