Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for the reusable collection view component #232

Open
hybridcattt opened this issue Jul 15, 2020 · 5 comments
Open

Add unit tests for the reusable collection view component #232

hybridcattt opened this issue Jul 15, 2020 · 5 comments
Labels
good first issue Good for newcomers test-cases This issue/PR is about test coverage

Comments

@hybridcattt
Copy link
Member

hybridcattt commented Jul 15, 2020

Summary

CollectionViewManager is a reusable class that reduces boilerplate when working with collection views.

How does it improve the project?

Collection views power all of the lists in the app. Having some tests verify that the reusable code works as expected is beneficial because it reduces potential for bugs and reduces need for as much manual testing.

Moved from Trello:
https://trello.com/c/WleVagW9/120-add-tests-for-collectionviewmanager

@hybridcattt hybridcattt added good first issue Good for newcomers test-cases This issue/PR is about test coverage labels Jul 15, 2020
@pastre
Copy link

pastre commented Oct 5, 2021

What is the reusable code? I can work on this :)

@hybridcattt
Copy link
Member Author

Hi @pastre, the class in question is this one: https://github.com/Say-Their-Name/say-their-names-ios/blob/development/SayTheirNames/Source/Components/CollectionViewManager/CollectionViewManager.swift

You should probably know that the app is not under active development, but it is live on the App Store.
We are temporarily experiencing issues with the backend right now, but that should be resolved shortly.

You are welcome to contribute and we/I will gladly review your contribution! 🙏

@pastre
Copy link

pastre commented Oct 14, 2021

Great! Will be working on it then

@pastre
Copy link

pastre commented Oct 15, 2021

@hybridcattt Apparently I don't have the permission to push to this repository. Do I need a fork?

@hybridcattt
Copy link
Member Author

@pastre yeah please create a fork 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers test-cases This issue/PR is about test coverage
Projects
None yet
Development

No branches or pull requests

2 participants