Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(emoji): fix emoji reaction wrap #1967

Merged
merged 1 commit into from
Apr 10, 2024
Merged

fix(emoji): fix emoji reaction wrap #1967

merged 1 commit into from
Apr 10, 2024

Conversation

Flemmli97
Copy link
Collaborator

@Flemmli97 Flemmli97 commented Apr 9, 2024

What this PR does 📖

  • Fixes problem where adding lots of emoji reactions does not wrap.
  • Renamed aria label from message-reaction-container to message-reactions-container since the class uses reactions
  • Removed margin of emoji container since that handled by the parent now
  • Also reduced overall size of emoji reactions as previously they where as big as the text message

Which issue(s) this PR fixes 🔨

@github-actions github-actions bot added Don't merge yet DO NOT MERGE Missing dev review Still needs to be reviewed by a dev Failed Automated Test This PR is failing Luis's Appium test and needs revised labels Apr 9, 2024
Copy link
Contributor

github-actions bot commented Apr 9, 2024

UI Automated Test Results Summary for MacOS/Windows

366 tests   307 ✅  2h 28m 23s ⏱️
 35 suites   57 💤
  3 files      1 ❌  1 🔥

For more details on these failures and errors, see this check.

Results for commit b1213ab.

Copy link
Contributor

github-actions bot commented Apr 9, 2024

UI Automated Tests execution is complete! You can find the test results report here

@phillsatellite phillsatellite added QA Tested QA has tested and approved and removed Failed Automated Test This PR is failing Luis's Appium test and needs revised labels Apr 9, 2024
@phillsatellite
Copy link
Contributor

Test is failing due to aria label change Luis has a PR in the test repo for that already when this is merged I will go make the change needed on Luis's PR and then merge that in as well so tests should be back to normal after that 👍

@dariusc93 dariusc93 added Ready to Merge This PR is ready to merge and removed Missing dev review Still needs to be reviewed by a dev Don't merge yet DO NOT MERGE labels Apr 10, 2024
@phillsatellite phillsatellite merged commit 38d3b4f into dev Apr 10, 2024
12 of 30 checks passed
@phillsatellite phillsatellite deleted the emoji_reaction_fix branch April 10, 2024 15:16
@github-actions github-actions bot removed QA Tested QA has tested and approved Ready to Merge This PR is ready to merge labels Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants