-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(chat): Add toasts to various quickprofile actions #1961
Conversation
UI Automated Test Results Summary for MacOS/Windows507 tests 447 ✅ 3h 0m 56s ⏱️ Results for commit 4de9f86. ♻️ This comment has been updated with latest results. |
UI Automated Tests execution is complete! You can find the test results report here |
Sara and I noticed if you block someone you are already friends with no toast will appear. If you block someone who you are not friends with toast will appear Removing someone I am not friends with toast.movRemoving someone I am friends with no.toast.mov |
if you are in a dm it and block someone via this the chat will close causing the component to unmount and thus unable to send a toast. after some discussions in the meeting though it should be fine to ignore this case as the chat closing is enough of user feedback and doesn't require a toast |
What this PR does 📖
This potentially should solve #1833.
For the overlapping part it should be resolved with the Unknown name.
Not too sure about the actions. Maybe they did work in the issue but due to lack of feedback which should be solved via the toasts now it gave the illusion it didn't.