Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chat): Add toasts to various quickprofile actions #1961

Merged
merged 3 commits into from
Apr 5, 2024

Conversation

Flemmli97
Copy link
Collaborator

What this PR does 📖

  • Adds various toast notification that were missing for various quickprofile notifications like sending friend request, blocking etc.
  • Display "Unknown" if the identity couldn't be resolved

This potentially should solve #1833.
For the overlapping part it should be resolved with the Unknown name.
Not too sure about the actions. Maybe they did work in the issue but due to lack of feedback which should be solved via the toasts now it gave the illusion it didn't.

@github-actions github-actions bot added Don't merge yet DO NOT MERGE Missing dev review Still needs to be reviewed by a dev labels Apr 3, 2024
Copy link
Contributor

github-actions bot commented Apr 3, 2024

UI Automated Test Results Summary for MacOS/Windows

507 tests   447 ✅  3h 0m 56s ⏱️
 44 suites   60 💤
  3 files      0 ❌

Results for commit 4de9f86.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Apr 3, 2024

UI Automated Tests execution is complete! You can find the test results report here

@phillsatellite
Copy link
Contributor

Sara and I noticed if you block someone you are already friends with no toast will appear. If you block someone who you are not friends with toast will appear

Removing someone I am not friends with

toast.mov

Removing someone I am friends with

no.toast.mov

@phillsatellite phillsatellite added the Changes requested When other dev or QA request a change label Apr 3, 2024
@Flemmli97
Copy link
Collaborator Author

Sara and I noticed if you block someone you are already friends with no toast will appear. If you block someone who you are not friends with toast will appear

Removing someone I am not friends with

toast.mov

Removing someone I am friends with

no.toast.mov

if you are in a dm it and block someone via this the chat will close causing the component to unmount and thus unable to send a toast.

after some discussions in the meeting though it should be fine to ignore this case as the chat closing is enough of user feedback and doesn't require a toast

@Flemmli97 Flemmli97 removed the Changes requested When other dev or QA request a change label Apr 4, 2024
@phillsatellite phillsatellite added the QA Tested QA has tested and approved label Apr 4, 2024
@dariusc93 dariusc93 added Ready to Merge This PR is ready to merge and removed Missing dev review Still needs to be reviewed by a dev Don't merge yet DO NOT MERGE labels Apr 5, 2024
@stavares843 stavares843 merged commit 8142b4f into dev Apr 5, 2024
4 checks passed
@stavares843 stavares843 deleted the quickprofile_notifications branch April 5, 2024 16:19
@github-actions github-actions bot removed QA Tested QA has tested and approved Ready to Merge This PR is ready to merge labels Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants