Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): make modals in chat render on top of all #1960

Merged
merged 2 commits into from
Apr 3, 2024
Merged

fix(ui): make modals in chat render on top of all #1960

merged 2 commits into from
Apr 3, 2024

Conversation

Flemmli97
Copy link
Collaborator

What this PR does 📖

  • Makes modals in chat render on top of other components fixing e.g. the sidebar being on top while viewing a file in chat

Which issue(s) this PR fixes 🔨

@github-actions github-actions bot added Don't merge yet DO NOT MERGE Missing dev review Still needs to be reviewed by a dev labels Apr 3, 2024
@phillsatellite phillsatellite added the QA Tested QA has tested and approved label Apr 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 3, 2024

UI Automated Test Results Summary for MacOS/Windows

507 tests   447 ✅  3h 2m 13s ⏱️
 44 suites   60 💤
  3 files      0 ❌

Results for commit b0acbdf.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 3, 2024 •
edited
Loading

UI Automated Tests execution is complete! You can find the test results report here

@dariusc93 dariusc93 added Ready to Merge This PR is ready to merge and removed Missing dev review Still needs to be reviewed by a dev Don't merge yet DO NOT MERGE labels Apr 3, 2024
@stavares843 stavares843 added Waiting for CI Waiting for at least one CI job to complete before merging and removed QA Tested QA has tested and approved Ready to Merge This PR is ready to merge labels Apr 3, 2024
@stavares843 stavares843 merged commit da442f6 into dev Apr 3, 2024
7 checks passed
@stavares843 stavares843 deleted the modal_stacking_fix branch April 3, 2024 23:26
@github-actions github-actions bot removed the Waiting for CI Waiting for at least one CI job to complete before merging label Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillsatellite phillsatellite phillsatellite approved these changes

@stavares843 stavares843 stavares843 approved these changes

@dariusc93 dariusc93 dariusc93 approved these changes

Assignees

@Flemmli97 Flemmli97

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(ui): favorites showing while viewing chat files
4 participants
@Flemmli97 @dariusc93 @stavares843 @phillsatellite