Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(keybinds): Close Inspector keyboard shortcut not working on Windows #1860

Closed
luisecm opened this issue Feb 19, 2024 · 2 comments
Closed
Assignees
Labels
assigned 💻 blocked bug 🐛 Settings Tickets that have to do with Settings

Comments

@luisecm
Copy link
Contributor

luisecm commented Feb 19, 2024

Note 1: Keyboard shortcut is working for opening Web Inspector on Windows, but when sending keyboard shortcut to close Inspector on Windows, nothing happens

Note 2: Keyboard shortcut works correctly on macos

  1. Login with any user
  2. Enable Developer Settings
  3. Enable Developer Mode
  4. Press Control + Shift + I - Web Inspector is opened
  5. Again, press Control + Shift + I - Web Inspector is not closed
@luisecm luisecm added Settings Tickets that have to do with Settings new ticket 💥 bug 🐛 and removed new ticket 💥 labels Feb 19, 2024
@lgmarchi lgmarchi self-assigned this Feb 28, 2024
@lgmarchi
Copy link
Contributor

/// Close the web inspector which is usually called dev tool.
///
/// ## Platform-specific
///
/// - Windows / Android / iOS: Not supported.
#[cfg(any(debug_assertions, feature = "devtools"))]
pub fn close_devtools(&self) {
self.webview.close_devtools();
}

/// Gets the devtool window's current visibility state.
///
/// ## Platform-specific
///
/// - Windows / Android / iOS: Not supported.
#[cfg(any(debug_assertions, feature = "devtools"))]
pub fn is_devtools_open(&self) -> bool {
self.webview.is_devtools_open()
}

It is not supported on Windows unfortanely.

@luisecm
Copy link
Contributor Author

luisecm commented Mar 21, 2024

Closing this issue for now, based on comment from @lgmarchi since this is not supported by Wry yet

@luisecm luisecm closed this as completed Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned 💻 blocked bug 🐛 Settings Tickets that have to do with Settings
Projects
None yet
Development

No branches or pull requests

2 participants