Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--benchmark command line argument crashes #1175

Closed
kyamant opened this issue Jan 2, 2025 · 1 comment
Closed

--benchmark command line argument crashes #1175

kyamant opened this issue Jan 2, 2025 · 1 comment

Comments

@kyamant
Copy link

kyamant commented Jan 2, 2025

On Windows11, tried to benchmark the trianglevulkan13 app by specifying --benchmark command line argument.
The app crashes at
std::cout << "Benchmark finished" << "\n";
of the
Benchmark::run(std::function<void()> renderFunc, VkPhysicalDeviceProperties deviceProps) function.
When I also specify --validation argument, it works fine since it invokes
setupConsole("Vulkan example");
in vulkanexamplebase.cpp and std::cout becomes available

@SaschaWillems
Copy link
Owner

While it shouldn't crash, explicitly opening a console in benchmark mode is not intended. Benchmark is supposed to be explicitly run from an existing console, so you get the benchmark result outputted to that console:

image

I'll try to find a way to make the sample not crash when doing benchmark and not explicitly being run from a terminal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants