-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
composer.lock require section is not updated #61
Comments
We have the same issue. This is really a great tool; but our problem use case is when we change the version of a My thought was to have composer-link dynamically replace the linked package's repository with a local path-based repository, which (again, I assume) would make composer respect the local composer.json file, and its changes. I'm just starting to review it, but it looks like composer link does this, or something like it, already. I'm not at all familiar with Composer's api, so kind of feeling around in the dark. |
This weekend I should have time to look into this. I think I will be able to create some tests for this, and hopefully resolve the issue afterwards. |
@develop-bvi106 After reading what the issue exactly is, I think that you mean the following feature: #18 So let's say we have a project and that project requires Now we want to link The issues that I linked doesn't have that much information in it, but I wanted to add this as a feature. I'm think about the following solution: I already experimented a bit with that feature, but it seemed a bit complex but not impossible, nevertheless I will try to continue with this feature this weekend. Would this work for you? |
Thanks for the prompt reply! What you describe would meet our requirements, although it would involve re-linking if the It looks like you have a lot of work into this approach already, but just to brainstorm: last night I started to look at subscribing to |
Yes so changes in the dependencies of the linked packages will require a new
Yes, because for most projects it's import to commit the lock file and also a good amount of libraries choose to commit their lock file, so this tool is really for development purpose to make easy changes/bugfixes in an included libraries. In composer you could also define path repositories as described here: |
@SanderSander sounds perfect to us, is exactly what we need for. Meanwhile we found a workaround: commiting the modified branch with new dependencies on github and modifying composer.json in parent project, did the trick
and then reference the package version as: launching composer update org/framework actually updates correctly the parent project |
Hi,
i'm using this awesome plugin for our local development.
Let's say i have
PROJECT1
usingPACKAGE1
via composer link, after having installed new dependencies onPACKAGE1
, thecomposer dump-autoload
in PROJECT1 doesnt see new dependencies installed and doesn't autoload new modules.I've noted that, also after
composer update PACKAGE1
, thecomposer.lock
require
section is not updated using the require section of the localCOMPONENT1
but seems it's using the published package dependencies on Packagist, it does update the composer.lock hash but doesn't reflect the required dependencies changes in the parent composer.lock file.We have many others dependencies in PACKAGE1 composer.json\require (already published on Packagist) that are loaded correctly from the parent project.
Maybe i'm missing something or have messed up with package dependencies, any help would be greatly appreciated!
The text was updated successfully, but these errors were encountered: