Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foundry compatibility can be improved by reducing npm/js dependency #7

Open
0xsuryansh opened this issue Feb 28, 2024 · 0 comments
Open

Comments

@0xsuryansh
Copy link
Member

0xsuryansh commented Feb 28, 2024

Thinking about simplifying our repo's dependency management, particularly in the oapp subdirectory, by replacing npm dependencies with direct path mappings like so:

remappings = [
    '@openzeppelin/contracts/=../lib/openzeppelin-contracts/contracts/',
    '@openzeppelin/contracts-upgradeable/=../lib/openzeppelin-contracts-upgradeable/contracts/',
    'solidity-bytes-utils/=../lib/solidity-bytes-utils',
    'hardhat-deploy/=../lib/hardhat-deploy/',
]

This could make integration easier for Foundry users but might have trade-offs, such as compatibility issues with tools like pnp-berry. I'm considering implementing this refactor unless there are significant downsides. Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant