Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: register the number of particles of each kind #66

Open
MatthieuSchaller opened this issue Jun 12, 2021 · 3 comments
Open

Comments

@MatthieuSchaller
Copy link
Member

Is that possible? It would let us fix the "zoom" problem bu ignoring structures dominated by background particles.

Other option, store the mass by type but also for the background particles.

@EvgeniiChaikin
Copy link
Collaborator

Yes, and it is actually rather easy to do - I've just checked.

If VR is compiled with ZOOM_SIM - which is of course true for zooms - then in the output catalog, there is a field Mass_interloper telling us the total mass of the background particles.

We need to decide though how exactly we want to get rid of the problematic haloes.

E.g.,

  • It could be done as part of another post-processing script (which would generate a new halo catalogue devoid of the problematic haloes)
  • Or, which I think is the best way, we could just apply a mask to the SMHM plots. I really like this idea because in the auto plotter all the code for applying masks has already been written by Josh a long time ago, so adding a new mask is very straightforward.

@MatthieuSchaller
Copy link
Member Author

Yes, a mask removing haloes that are heavily contaminated would be best. If the corresponding contamination count is already picked up by the VR python module then it's all easy to do indeed in the pipeline code.

@james-trayford
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants