Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: SOAP reports centres outside of box #106

Open
kyleaoman opened this issue Sep 18, 2024 · 0 comments
Open

Bug: SOAP reports centres outside of box #106

kyleaoman opened this issue Sep 18, 2024 · 0 comments
Assignees

Comments

@kyleaoman
Copy link
Member

Seems like there are probably some places where the box should be wrapped before writing output, for example:

>>> import h5py
>>> import os
>>> base = "/cosma8/data/dp004/colibre/Runs/L0050N0376/Fiducial_test/SOAP"
>>> snapfile = os.path.join(base, "colibre_with_SOAP_membership_0127.hdf5")
>>> soapfile = os.path.join(base, "halo_properties_0127.hdf5")
>>> f = h5py.File(soapfile, "r")
>>> com = f["BoundSubhalo/CentreOfMass"][...]
>>> com.min()
-0.017256109013965164
>>> com.max()
50.00512234260799
>>> f["Header"].attrs["BoxSize"]
array([50.00000002, 50.00000002, 50.00000002])
@robjmcgibbon robjmcgibbon self-assigned this Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants