This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 472
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixed the crono job overflowing the
log
column
Before this commit, the crono job kept on adding the log into the `log` column from the `crono_jobs` table. This is, of course, a bad thing. What I did to fix this is to simply remove this columns from the DB, and crono is ok with that. Running crono again with this patch runs in the very same way as it used to be, but without adding the log all the time. Moreover, the log is supposed to go to the stdout, as envisioned by the Twelve-Factor App manifesto: http://12factor.net. Docker follows this too, and by doing so then the log of this job blends in with docker-compose logs command. This has two main consequences: 1. The user can decide how to manage logs in an easier way, so there's no way that we run out of disk (an issue we were having). 2. supervisor is no longer needed. Instead, we take advantage of the compose-setup.sh script to do it properly. Before this patch, for some reason the catalog job did not reach the db container. Fixes #479 Fixes #505 Signed-off-by: Miquel Sabaté Solà <[email protected]>
- Loading branch information
Showing
6 changed files
with
14 additions
and
16 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,13 +4,8 @@ MAINTAINER Flavio Castelli <[email protected]> | |
ENV COMPOSE=1 | ||
EXPOSE 3000 | ||
|
||
# install supervisord, this is required to run cronos | ||
RUN apt-get update && apt-get install -y supervisor | ||
RUN ln -s /portus/docker/crono-supervisord.conf /etc/supervisor/conf.d/crono.conf | ||
|
||
WORKDIR /portus | ||
COPY Gemfile* ./ | ||
RUN bundle install --retry=3 | ||
|
||
ADD . . | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
class RemoveLogFromCronoJob < ActiveRecord::Migration | ||
def change | ||
remove_column :crono_jobs, :log, :text | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.