Replaces .includes with a regex for a better IE compatibility #1096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to address: #76
STRML
requested changes
Dec 7, 2019
lib/ReactGridLayout.jsx
Outdated
| @@ -101,7 +101,7 @@ const layoutClassName = "react-grid-layout"; | |||
| let isFirefox = false; | |||
| // Try...catch will protect from navigator not existing (e.g. node) or a bad implementation of navigator | |||
| try { | |||
| isFirefox = navigator.userAgent.toLowerCase().includes("firefox"); | |||
| isFirefox = new RegExp("firefox").test(navigator.userAgent.toLowerCase()); | |||
There was a problem hiding this comment.
Suggested change
| isFirefox = new RegExp("firefox").test(navigator.userAgent.toLowerCase()); | |
| isFirefox = /firefox/i.test(navigator.userAgent); |
lib/ReactGridLayout.jsx
Outdated
| @@ -721,7 +721,7 @@ export default class ReactGridLayout extends React.Component<Props, State> { | |||
| // to avoid unpredictable jumping of a dropping placeholder | |||
| if ( | |||
| isFirefox && | |||
| !e.nativeEvent.target.className.includes(layoutClassName) | |||
| !(new RegExp(layoutClassName).test(e.nativeEvent.target.className)) | |||
There was a problem hiding this comment.
Suggested change
| !(new RegExp(layoutClassName).test(e.nativeEvent.target.className)) | |
| e.nativeEvent.target.className.indexOf(layoutClassName) === -1 |
There was a problem hiding this comment.
I agree about the readability and I've done the changes. Should be fine now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to address: #76